My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 108: URL linkification pulls in trailing right parenthesis
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Dave Bort <dbort@android.com> on Tue Mar 24 16:26:37 PDT 2009
Source: JIRA GERRIT-108
Affected Version: 2.0.8

Change <https://review.source.android.com/Gerrit#change,9378> has a
description including the text:

"""
armv4 was only implemented on StrongArm and Arm8 (See http://en.wikipedia.org/wiki/ARM_architecture)
and will be more difficult to support since it does not support the bx
instruction.
"""

The auto-linked URL becomes "http://en.wikipedia.org/wiki/ARM_architecture)",
which incorrectly includes the right paren.  I'm pretty sure that most auto-
linkifiers would exclude the right paren in this case, but I don't know how
complicated it makes the regex (or whatever).
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Mar 24 16:47:36 PDT 2009

Hah.  RFC 1738 says ")" is legal in a URL.  Even JIRA is extracting it as a
legal character when it linkifies the URL on the web.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Dave Bort <dbort@android.com> on Tue Mar 24 16:52:33 PDT 2009

Yeah, figured.  I bet gmail has "exclude close brace/paren/angle at the end of
URLs" logic or something.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Mar 24 16:54:23 PDT 2009

} and > are not legal in a URL per the RFC.

I'm attempting to teach Gerrit the full RFC rules, but use what you suggest,
which is to ignore trailing ) if it is the last character.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Mar 24 16:58:29 PDT 2009
Labels: Component-gwtexpui
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Mar 24 17:02:41 PDT 2009
Sep 24, 2009
#6 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Mar 24 17:02:46 PDT 2009

Fixed by https://review.source.android.com/9380
Sep 24, 2009
#7 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Mar 30 08:39:45 PDT 2009
Sep 24, 2009
#8 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Mar 30 08:39:52 PDT 2009

Fixed by https://review.source.android.com/9434
Sep 24, 2009
#9 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Mar 30 08:39:52 PDT 2009

Fixed in version 2.0.9.
Status: Fixed
Sep 25, 2009
#10 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.9
Oct 25, 2012
#11 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting