My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 105: openid4java doesn't work behind proxy
  Back to list
Status:  Released
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Wed Mar 18 17:19:36 PDT 2009
Source: JIRA GERRIT-105
Affected Version: 2.0.8

According to openid4java's documentation https://code.google.com/p/openid4java/wiki/ConsumerForwardProxy

> If your Relying Party / consumer site needs to access the internet through a
proxy, the following proxy configuration is necessary, before the
ConsumerManager is instantiated:
>
> // --- Forward proxy setup (only if needed) ---
> ProxyProperties proxyProps = new ProxyProperties();
> proxyProps.setProxyName("proxy.example.com");
> proxyProps.setProxyPort(8080);
> HttpClientFactory.setProxyProperties(proxyProps);

To make this work Gerrit needs a code change to permit proxy configuration.
We don't do this HttpClientFactory.setProxyProperties(proxyProps) call they
recommend.

FWIW, the init code would probably need to go in OpenIdServiceImpl's
constructor.  The proxy settings could go in a file in $site_path, or in the
system_config table.  Either are available off that GerritServer instance the
constructor is already fetching.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Mar 19 07:34:45 PDT 2009

See this repo-discuss post:

  http://groups.google.com/group/repo-discuss/msg/f616e04e6382fc6c
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Mar 26 14:19:13 PDT 2009
Labels: -Priority-Minor Priority-Trivial
Sep 24, 2009
#3 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Nov 17, 2009
#4 sop+code@google.com
Change I6482405b942acad6275fc0cf4be86d67bf7dba48
Status: Fixed
Labels: FixedIn-2.0.25
Dec 18, 2009
#5 sop@google.com
(No comment was entered for this change.)
Labels: FixedIn-2.1
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting