My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1004: Clicking the button to go to next/prev file fails when the next/prev file is an image
4 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by hughdave...@gmail.com, Jun 7, 2011
Affected Version: 2.1.7.2

What steps will reproduce the problem?
1. Upload a patch with an image in the middle of the set
2. Go to web interface, and click on the file before the image
3. Click the link to go to next file

What is the expected output? What do you see instead?
I expected:
Go to next file, or skip over image
I saw:
A quick flash of loading up the top, and then browser staying on same file


Please provide any additional information below.
Chromium 11.0.696.71 (86024) Ubuntu 11.04
also Firefox 4.0.1
Jun 7, 2011
#1 hughdave...@gmail.com
It seems this is only with some images.

An example one that gerrit doesn't open is attached
flickr.png
281 bytes   View   Download
Jan 17, 2012
#2 nate.bau...@gmail.com
This happens on my build (v. 2.2.1) with png images that contain an alpha channel. (Not sure if it happens with other images or not.)
Jan 17, 2012
#3 jacob.feisley
This issue also occurs on 2.2.1 for many binary files (i.e. archives, images, other blobs).

Perhaps the UI should simply show the file metadata and/or note that it is a binary format that cannot be displayed. 
Feb 6, 2013
#4 JKiljan...@gmail.com
This bug still occurs and it's very annoying. Despite the fact, that I can't see prev/next file, I can't see it even when I'm clicking on it in Patch Set file list!

The only solution to review file is to checkout whole patch set.

Maybe it's time to increase the priority of this bug?

Gerrit ver. 2.5
Sign in to add a comment

Powered by Google Project Hosting