| Issue 765: | file list is not updated when changing patch sets while reviewing | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.5 What steps will reproduce the problem? 1. Push a commit which adds file 'a.txt' and 'b.txt' 2. Amend the commit so that the commit now adds file 'b.txt' and 'c.txt' and push again to the same change 3. As result you will have a change with 2 patch sets, patch set 1 adding files 'a.txt' and 'b.txt' and patch set 2 adding the files 'b.txt' and 'c.txt' 4. Go to the change in the Gerrit WebUI and open the side-by-side diff for file 'b.txt' of patch set 2 5. Note that with the displayed navigation links you can navigate backwards to the diff of the commit message and forwards to the diff for file 'c.txt' (this is as expected) 6. Now open the Patch History and choose Patch Set 1 as New Version (leave Old version to base) 7. Remember that Patch Set 1 changed the files 'a.txt' and 'b.txt' and notice that the displayed navigation links are not updated, you can still only navigate backwards to the commit message and forwards to file 'c.txt' which does not exist in patch set 1, there is no possibility to navigate to file 'a.txt' which was added in patch set 1 8. Press 'f' to open the File List for the currently reviewed patch set, it still shows the file set for patch set 2 although we have now selected patch set 1 for review What is the expected output? What do you see instead? I would expect that the file list and displayed navigation links always match the patch set that is selected in the Patch History. Even more if I'm comparing two patch sets I would expect to see in the file list the superset of the files from the two patch sets being compared, e.g. with the above example, if I'm comparing patch set 1 and patch set 2 I would expect to see the files 'a.txt', 'b.txt' and 'c.txt' in the file list. Please provide any additional information below.
Jun 8, 2011
Project Member
#1
nas...@codeaurora.org
Status:
Accepted
Feb 17, 2012
This still present on 2.2.2? |
|
| ► Sign in to add a comment |