My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 667: highlight old patch sets that have drafts
22 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Apr 2013


Sign in to add a comment
 
Reported by AlenLPea...@gmail.com, Aug 19, 2010
Affected Version:

What steps will reproduce the problem?
1. make inline comments on one file in a patchset
2. forget to go back and hit "Review" then "Publish Comments"
3. wait for author to create a new patchset
4. notice (or more likely don't notice) that the comments are never seen by anyone.

What is the expected output? What do you see instead?
I would expect gerrit to warn me that I have written comments that haven't been published. Instead, they just disappear and I have no idea they are gone unless I go through changesets, expanding previous patchsets, or keep a close eye on https://gerrit/#q,has:draft,n,z

Please provide any additional information below.
The workflow surrounding inline comments is confusing. There should be a button on each comment to publish, or at least on each file review page. Making the user go back after reviewing all the files in a changeset and doing two more click-throughs to publish seems like unnecessary work, and is easy for the user to forget. Even worse, if the user does forget to do this, gerrit doesn't ever really warn them about it... the comments are just lost to posterity.

But, I can understand why this workflow is in place -- it's nice to be able to edit inline comments before publishing them. If the existing workflow is kept, I'd suggest highlighting changesets that have comments in "(Draft)" state prominently on the dashboard.
Aug 19, 2010
#1 sop@google.com
We aren't going to change the workflow, as each publish
event triggers an email message and users wouldn't want
to get them per-file.

But you are right, we should highlight where you have stale
drafts on the change page so you don't need to hunt down
the location yourself.
Status: Accepted
Aug 19, 2010
#2 sop@google.com
(No comment was entered for this change.)
Summary: highlight old patch sets that have drafts
Sep 30, 2010
#3 kiril.ar...@gmail.com
Highlighting of stale draft comments will be great. 

I have one suggestion - why don't show a dialog to the user to publish the draft comments for previous patch set, if he/she wants to publish comments for the latest patch set - in that way at least the reviewer will notice the unpublished comments and could take some action.
Oct 8, 2010
#4 di...@google.com
One local user has asked us for the same thing. We want to have on the change page some text on the right side of each patch set (even when collapsed) saying something like "Drafts Pending", making it clear there are draft messages not sent there.

A second (but related) feature requested was that when publishing comments on a patch set Gerrit could check if there are other patch sets with drafts and provide Review buttons for those on the comments sent confirmation dialog. Please let me know if you want me to open a separate issue about this second requests.
Oct 26, 2010
#5 jessewil...@google.com
Sometimes I'll upload a new patch set while my reviewer is reviewing. When he finally publishes his review, the line-by-line comments are lost!

It would be nice if "Publish Comments" defaulted to include the drafts from all patch sets.
Feb 23, 2011
#6 jessewil...@google.com
Could Gerrit be fixed to not collapse patch sets that have drafts? It's too easy to lose draft comments.
May 29, 2012
#7 k...@google.com
I lost comments too. It'd be nice if this was fixed.
May 29, 2012
#8 b...@google.com
happened to me on a CL this week where I had been going back and forth with comments  on a PS1 while the author uploaded PS2, and I never submitted the last round of PS1 comments.
Apr 16, 2013
Project Member #9 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/44630/
Status: Submitted
Labels: FixedIn-2.7
Sep 20, 2013
Project Member #10 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting