My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3625: NewProjectCreatedListener.onNewProjectCreated is called synchronously on listeners, causing new project creations to block when a listener takes a long time
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Oct 20, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11.4 / master

What steps will reproduce the problem?
1. Install the replication plugin
2. Create a new project
3.

What is the expected output? What do you see instead?

When the new project is created, the replication plugin's onNewProjectCreated listener is called (along with the same method on any other registered NewProjectCreatedListener instances).

This will iterate over all the configured destinations and create the project on those destinations.

If the project creation takes a long time, for example if the connection to the remote is slow, then this will cause the project creation to block.

When creating a project from the UI, this manifests as "Working" being displayed until the operation was completed.  When creating a project from the REST API, the request does not complete until the replication was completed.

Please provide any additional information below.

At the point where the listeners are invoked, the project has already been created on the master.  It should be OK to invoke the listeners asynchronously so that the request can return without blocking.


Oct 20, 2015
Project Member #1 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/71720/
Status: ChangeUnderReview
Oct 21, 2015
Project Member #2 dougk....@gmail.com
 Issue 3412  has been merged into this issue.
Dec 17, 2015
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: New
Sign in to add a comment

Powered by Google Project Hosting