My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3297: Simplify rebase dialog
2 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by Martin.W...@gmail.com, Apr 15, 2015
Currently the rebase dialog has one checkbox 'change parent revision' and one text field which is only active when that text box is enabled.

Instead we could simply pre-fill the text box with the current parent change
(or leave it empty if the parent change is already merged).
The checkbox can be removed completely.
The help text currently shown when the text box is empty could be moved to a label above the text box.
The 'rebase' button would be enabled if the selected parent is different from the current one.
If the user did not change the parent field then it would be enabled when there is a new patchset in the parent change or a new commit on the target branch.

That way, the user can directly manipulate the parent change.
Especially removing the dependency on the parent change would be much more natural.
Apr 15, 2015
Project Member #1 david.pu...@sonymobile.com
Agree with the suggested changes to the functionality, but this is unlikely to be done for 2.11.
Status: Accepted
Apr 15, 2015
#2 zalan.bl...@gmail.com
Unfortunately performance and usability do not always go hand-in-hand ...

Rebasing onto a new parent is not the typical Rebase use-case. The 'change parent revision' checkbox was added to to save an additional (potentially heavy) query in the typical case (no parent change). 
Apr 17, 2015
#3 Martin.W...@gmail.com
Why would you need an additional query?
The client already knows the parent change (it is also displayed in the "related changes" tab).
If the text field hasn't been changed by the user (can be determined with a simple string comparison) then that is equivalent to not checking the 'change parent revision' checkbox.
So the typical use case shouldn't be any more expensive than now.
Sign in to add a comment

Powered by Google Project Hosting