My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3256: Conflicting changes list unusable for extremely large reviews
4 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Project Member Reported by dougk....@gmail.com, Mar 19, 2015
Affected Version: 2.9.1

What steps will reproduce the problem?
1. Create a review with several hundred files moved/changed
2. View change in Gerrit

What is the expected output? What do you see instead?

The "Change Conflicts With" section is replaced by the large query "400 cannot create query for index: (...)" where the query is a list of all files modified.

Please provide any additional information below.

Note that we are configured using the Lucene secondary index.  This issue is certainly abnormal (it normally works okay), but seems to be related to the absurdly large change.  I wouldn't expect the query parser to be able to keep up with such a convoluted query, but it would be nice to have a cleaner handling of the error such as "Conflicting changes are not available."
Mar 19, 2015
Project Member #1 edwin.ke...@gmail.com
You can increase the maximum number of clauses permitted for queries:
  https://gerrit-documentation.storage.googleapis.com/Documentation/2.11/config-gerrit.html#index.defaultMaxClauseCount
Mar 19, 2015
Project Member #2 dougk....@gmail.com
Hmm, that'd be a workaround, at least.  I'm just thinking of the presentation to the user when the count does exceed that limit should be a bit cleaner, rather than spewing the entire query back at the user.

Thanks Edwin!
Apr 22, 2015
#3 Martin.W...@gmail.com
A simple note that conflicting changes are not shown for so large commits would really help.

We encountered this bug a few times while refactoring our repository and all users immediately go "arg, what did I do wrong? I broke Gerrit!" when they saw such a change.
Dec 31, 2015
Project Member #4 zaro0508
Yep, I had the same reaction: https://groups.google.com/forum/#!topic/repo-discuss/GztxFlO1AEU

Jan 8 (2 days ago)
Project Member #5 dougk....@gmail.com
Should be fixed in https://gerrit-review.googlesource.com/71580
Status: Released
Labels: FixedIn-2.12
Jan 8 (2 days ago)
#6 dborowitz@google.com
I never said it was fixed, I just said the error message would be slightly better. You're still gonna get an error and it's still not gonna be pretty in the UI.
Jan 8 (2 days ago)
Project Member #7 dougk....@gmail.com
Sorry, I must have misinterpreted your email then. :)
Status: Accepted
Labels: -FixedIn-2.12
Sign in to add a comment

Powered by Google Project Hosting