My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2894: Gerrit links to gitweb if a related change is merged
7 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----
Cc:  edwin.ke...@gmail.com


Sign in to add a comment
 
Reported by pedah...@gmail.com, Sep 10, 2014
Affected Version: 2.8.5

What steps will reproduce the problem?
1. Push a patch
2. See that there are related changes
3. Merge one of the related changes
4. Related change in related changes list now links to gitweb, not the URL for the review.

What is the expected output? What do you see instead?

I expect it to continue to link to the Gerrit review. We have an external gitweb, and some of our repositories are not available via the gitweb links, so this generates a 404.  We would like (at minimum) a config option to tell whether the related changes links to Gerrit or gitweb when a change is merged.

Please provide any additional information below.

Dec 9, 2014
Project Member #1 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/62236
Status: ChangeUnderReview
Jan 2, 2015
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11
Feb 19, 2015
Project Member #3 david.pu...@sonymobile.com
 Issue 3193  has been merged into this issue.
Apr 8, 2015
Project Member #4 david.pu...@sonymobile.com
 Issue 3283  has been merged into this issue.
Cc: edwin.ke...@gmail.com
Apr 8, 2015
Project Member #5 david.pu...@sonymobile.com
Re-opening because it's not working as expected.
Status: Accepted
Labels: -FixedIn-2.11
Apr 9, 2015
Project Member #6 edwin.ke...@gmail.com
I just tested this on stable-2.11 (059f3cf25e63de77b3f94e8298d7e7f95dc5b400) and there it works fine. It's broken in master.
Labels: FixedIn-2.11
Apr 9, 2015
Project Member #7 edwin.ke...@gmail.com
*only
Apr 9, 2015
Project Member #8 edwin.ke...@gmail.com
Okay, this fix was actually reverted in master [1]. If there is a problem with this fix I suggest that we should cherry-pick the revert to 2.11 [2].

[1] https://gerrit-review.googlesource.com/66289
[2] https://gerrit-review.googlesource.com/66990
Labels: -FixedIn-2.11
Jun 19, 2015
Project Member #9 edwin.ke...@gmail.com
[1] should fix most cases, but there are still some conditions in which we would link to gitweb.

[1] https://gerrit-review.googlesource.com/68704
Sign in to add a comment

Powered by Google Project Hosting