My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2372: ChangeScreen2: Related Changes hierarchy is unclear
22 people starred this issue and may be notified of changes. Back to list
Status:  ChangeUnderReview
Owner:  ----


Sign in to add a comment
 
Reported by org...@gmail.com, Dec 29, 2013
Affected Version: 2.8, 2.9

In the previous change screen the parent-child relation was clear (Depends On, Needed By). Now it is all mixed up in a single list.

A gitk-like UI could be useful here.
Jan 16, 2014
#1 matthias...@gmail.com
It would be also useful to not hide this parent-child relations after a change has been submitted
Jan 22, 2014
#2 nic...@eriksson.cc
The related changes doesn't show merged, outdated etc. either.

Imho that was a very useful feature of the old dependencies list. Might be that this information has simply been moved and that I'm missing something?
Jan 22, 2014
Project Member #3 David.Os...@gmail.com
 > In the previous change screen the parent-child relation was clear (Depends On, Needed By). Now it is all mixed up in a single list.

Clarified in this change [1]:

Unlike the old change screen it doesn't explicitly say "needed by" and "depends
on" any more, but the relationship can still be inferred from the position of
the change in the list.  Changes listed above the current change are dependents;
changes below the current change are dependencies.

 > The related changes doesn't show merged, outdated etc. either.

Yes, it is there, at least on master [2]:

If the selected patch set of a change is older than its latest patch set, the change is marked with an orange dot.
If a descendant change depends on a patch set that is older than the selected patch set of a change, the descendent change is marked with a tilde (~).
If an ancestor commit is not associated to a Gerrit change, i.e. has been pushed directly to the repository bypassing review, it is marked with a black dot.

[1] https://gerrit-review.googlesource.com/#/c/53910/
[2] https://gerrit-review.googlesource.com/Documentation/intro-change-screen.html#related-changes
Jan 22, 2014
#4 org...@gmail.com
That's still not clear enough.

Suppose you have the following dependency graph:

A
|
|
|
B
|\
| \
| |
C D

This appears as
A
B
C
D

and you have no hint that C and D are mutually independent.
Aug 13, 2014
#5 mani.cha...@gmail.com
Hi,

I am planning to work on this issue. Can you please let me know how can we create mutually dependent changes.
Aug 13, 2014
#6 org...@gmail.com
echo 1 > file
git add file
git commit -m 'A'
echo 2 > file
git commit -a -m 'B'
echo 3 > file
git commit -a -m 'C'
git push origin HEAD:refs/for/master
git reset HEAD^
git commit -a -m 'D'
git push origin HEAD:refs/for/master

Aug 31, 2014
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: ChangeUnderReview
Sep 17, 2014
Project Member #9 huga...@gmail.com
change under review moved to master branch: https://gerrit-review.googlesource.com/#/c/59830/
Sign in to add a comment

Powered by Google Project Hosting