My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2351: Scrollbars in diff do not appear
32 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jul 2014


Sign in to add a comment
 
Reported by simp...@gmail.com, Dec 17, 2013
Under firefox 26.0 and also tested with Chrome 31, the new diff view truncates the text when there is horizontal overflow and simply does not scroll.

Affected Version: gerrit 2.8 with new change ui enabled

What steps will reproduce the problem?
1. open a review with long lines and/or resize the browser window to be narrow enough to force horizontal line overflow
2. open a file diff by in the change

What is the expected output? What do you see instead?

The line overflows, but no scroll bar are visible.
Resizing the browser window makes the 2 diff scrollbars appear but they don't seem to scroll completely and one of the diff viewport is still horizontally truncated.


Please provide any additional information below.

I also briefly tested this on the gerrit-review.googlesource.com server which is listed to be at version 2.8-875-g343a853 and even though the scroll bars appear, there is still some truncated text if the content of one of the diff pane is larger than the other

capture.png
75.6 KB   View   Download
Dec 30, 2013
#1 stayle...@gmail.com
When I set the browser Zoom in or Zoom out, the scroll bar will display.
Jan 6, 2014
#2 presich....@gmail.com

Are there any updates on this issue? Thanks!
Jan 31, 2014
#3 r.d.f.ch...@gmail.com
I can verify I get the same problem in safari, firefox and chrome (all latest versions at time of writing) on OS-X with gerrit 2.8.1 new change screen. Horizontal scroll is always missing when moving between file diffs either via keyboard or navigation buttons. Also missing if you go to the diff via a direct deep link. Scroll-bars re-appear as soon as you resize the browser window at all (until you next change file, then they're gone again).
Jan 31, 2014
#4 halcyon1...@gmail.com
It would also be great if the layout would take up the entire horizontal space on my screen.  I *shouldn't* need scroll bars at all, but it is artificially limited horizontally currently, and making this bug a problem.
Feb 14, 2014
#5 canuckot...@gmail.com
In my testing (don't know the specific version, sorry - somewhere in 2.8 but someone else is responsible for our server) I've found that any time I open a file, if there are enough changes in the file and long-enough lines in those changes to force both a vertical and a horizontal scroll bar, the horizontal scroll bar is invisible. I suspect it's just hidden under the info bar across the bottom ("Press '?' to view keyboard shortcuts" etc) but honestly that's pure guesswork. 

If I do anything to force the page layout to update - resizing the window in any way, for example - the horizontal scroll bar appears where it should be.

I've noticed the same behaviour whether I'm moving to a new file by clicking on it in a review or moving from one file to the next (either through the buttons or through keyboard shortcuts, in case that matters).
Feb 14, 2014
#6 halcyon1...@gmail.com
I believe its more than just hidden because when I try to scroll horizontally from my trackpad I cannot, then once I force a re-layout, I can.
Feb 19, 2014
#8 eriklov...@gmail.com
Could this issue get some attention? It's a very noticeable regression from previous versions of gerrit.
Feb 26, 2014
#9 simp...@gmail.com
Following comment #7, I applied a dirty workaround by adding a javascript block in GerritSiteFooter.html containing a call that listens for hash change. This makes things better while waiting for an official fix.

window.setTimeout(function(){window.dispatchEvent(new Event('resize'));},1000);
window.onhashchange = function(){
     window.setTimeout(function(){window.dispatchEvent(new Event('resize'));},1000);
};

Jun 18, 2014
#10 mani.cha...@gmail.com
I tried to replicate this issue in gerrit master (with firefox browser) by adding file with long lines but the scroll bar seem to be appearing. Is this issue already fixed in master? If yes, please share the link to change.
Jun 18, 2014
#11 simp...@gmail.com
I confirm this is  fixed in version 2.9-RC2
Jun 19, 2014
#12 mani.cha...@gmail.com
simp...@gmail.com
Thanks for confirmation.
Can you please share link to the change where it was fixed?
Jul 16, 2014
Project Member #13 zaro0508
(No comment was entered for this change.)
Status: Released
Jul 16, 2014
Project Member #14 edwin.ke...@gmail.com
(No comment was entered for this change.)
Labels: FixedIn-2.9
Sign in to add a comment

Powered by Google Project Hosting