My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1573: Deleting a symlink and adding a file with the same name and path as symlink causes review problems
9 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by a...@aerofs.com, Sep 19, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.4

What steps will reproduce the problem?
1. Commit a symlink
2. In a new patch set, delete the symlink and add a file with the same name as the symlink
3. Upload to Gerrit.

What is the expected output? What do you see instead?
Gerrit shows a deletion and addition of the same file and the review URLs for both are the same, in this case, showing deletion and not the content of the new file.

Please provide any additional information below.
Jan 17, 2013
Project Member #1 david.pu...@sonymobile.com
 Issue 1762  has been merged into this issue.
Sep 17, 2013
#2 krinklemail@gmail.com
The reverse is an issue as well. I still encounter this in Gerrit version 2.7-rc2-505-g7502a46.

The repo contains a text file somewhere, and the patch set removes the file and inserts a symlink instead.

Example: https://gerrit.wikimedia.org/r/#/c/84708/1

The patch set lists as follows:

	D	docroot/press/robots.txt		 	Side-by-Side	Unified	
 	A	docroot/press/robots.txt		1 line	Side-by-Side	Unified	
 	D	docroot/searchcom/robots.txt		 	Side-by-Side	Unified	
 	A	docroot/searchcom/robots.txt		1 line	Side-by-Side	Unified	
 	D	docroot/secure/robots.txt		 	Side-by-Side	Unified

However for each D/A pair, both the Deletion and Addition link are the same. The url in question in this case shows the diff for the removal, e.g. https://gerrit.wikimedia.org/r/#/c/84708/1/docroot/press/robots.txt 
Sign in to add a comment

Powered by Google Project Hosting