My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1207: Keyboard shortcut [ don't work when on all keyboards
74 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by robin.ro...@gmail.com, Dec 3, 2011
Affected Version: 2.2.1-67-g17ca55f

The [  (previous file) does not work on OS X (Safari/Firefox). Presumably this has
something to do with the fact that on a swedish keyboard the alt key is required
to type [.

Shorcuts like / and ?, that only require Shift, do work and for ] there is an alternative shortcut.
Mar 12, 2012
#1 moigoo...@nic.fi
This looks like the same thing:
Both [ and ] (previous/next file) are broken on Finnish keyboard layout (Win7, Chrome 17.0, gerrit 2.2.2.1). And yes, typing those characters requires the "Alt Gr" key.

What's the alternative shortcut for 'next file' ?
Mar 1, 2013
#2 bruno.bo...@gmail.com
Same problem here with german keyboard layout on OS X. Is there an alternative shortcut?
Jul 5, 2013
#3 maxime.g...@gmail.com
Here with win 7 / gerrit 2.7-rc2-529-ge348f21 it doesn't works either on chrome 27.0.1453.116 BUT it works with firefox 22.0.

(French keyboard, but i'm not sure it matters since it works fine with firefox)
Mar 4, 2014
#4 lauri.ja...@gmail.com
Some shortcuts does work, like "?" (shift +)
Some shortcuts does not work, like "]" (altgr 9)


OS: Windows 7, 
Browser: Chrome 33.0.1750.117 
Gerrit: 2.8.1
Keyboard: Finnish layout

Mar 13, 2014
#5 omark...@gmail.com
On the Spanish keyboard you have to type Ctrl+Alt+KEY to get [ and ]. KEY being the keys where [ and ] are located on the US keyboard.

On the OLD Change Screen this used to work to change between files while reviewing the diff. On the NEW Change Screen it doesn't work anymore, except when first clicking outside of the 'editor' (i.e. somewhere along the border of the website).

OS: Ubuntu 13.10
Browser: Firefox 27
Gerrit: 2.8
Keyboard: Spanish layout
May 15, 2014
#6 anpie...@gmail.com
On the German Keyboard you've to press Altgr + KEY.

While in Chrome (Version 34.0.1847.132 (265804)) it does work Firefox (29) fails on it.

OS: Archlinux
WindowManager: XMonad
Browser: Firefox 29
Gerrit: 2.8.5
Keyboard: German layout
Jul 8, 2014
#7 andreas....@gmail.com
Same here with a Swedish keyboard. On old screen it works with AltGr+9 but on new screen it doesn't.

OS: Linux Mint 14
Browser: Firefox 27.0
Gerrit: 2.8.5
Keyboard: Swedish
Nov 5, 2014
#8 o...@skyshaper.net
To add more weirdness to this the bindings are inconsistent on different screens.
We recently upgraded to 2.9 at work and the new file view is quite hard to use with a swedish keyboard.

In the patchset view [] works correctly but not in the file diff view
In the patchset view ? works correctly, but in the file diff view it starts a search. Despite the instructions saying it should show help. '/' Also starts the same search.

In the file view 'å' will take you to the next file, but there is no combo I found that will take you back. Using 'å' in the patchset view does not do anything.


While the new diff view seems to be aimed at being even more keyboard driven which is fantastic I think that it currently lacks a lot of support for non english keyboards. This really needs to be fixed. Especially since the bindings are different on different pages.

Since these problems seem to have been around for quite a long time I really think at least a response from the developers would be appropriate.

Cheers

Nov 14, 2014
#9 noseg...@gmail.com
I've noticed that if you click the top of the review in diff-view (e.g. above the diff) - as to give another element focus. Then [ and ] works.

On the next page 'that element' looses focus again so you'd have to re-click the top. Impractical.
Nov 24, 2014
#10 andreas....@freiheit.com
On a german keyboard pressing ? to access help, opens the backwards search when viewing a diff. Thus I cannot look up any shortcuts there.
Nov 25, 2014
Project Member #11 edwin.ke...@gmail.com
> On a german keyboard pressing ? to access help, opens the backwards search when 
> viewing a diff. Thus I cannot look up any shortcuts there.
This is not related to the key language but to where the focus is. If the focus is on the code mirror editor pressing ? opens the backwards search, if the focus is somewhere else you get the help on pressing ?.
Nov 26, 2014
#12 o...@skyshaper.net
>> On a german keyboard pressing ? to access help, opens the backwards search when 
>> viewing a diff. Thus I cannot look up any shortcuts there.
> This is not related to the key language but to where the focus is. If the focus is 
> on the code mirror editor pressing ? opens the backwards search, if the focus is somewhere else you get the help on pressing ?.

Indeed, the keybindings seem to work if I manually use the mouse to select the top or bottom area of the diff pages.

However, it's very hard to know what area of the page you are in since there is no visual indication, and there is no easy way of moving to the area where the keybindings work without using the mouse.

But I still think something is fishy with the key language. From what I can tell, most key bindings work except []. 
Nov 26, 2014
Project Member #13 edwin.ke...@gmail.com
My comment was only related to pressing ?, the issue with [] may depend on the key language.
Feb 12, 2015
#14 janne.ro...@vincit.fi
This issue is preventing many of our gerrit users to use the new change screen as [ and ] shortcuts do not work on the diff view

We are mainly using finnish keyboard layout where you get [ with altgr+8 and ] with altgr+9
Feb 13, 2015
#15 aleksi.h...@vincit.fi
Verified.

Just for a quick analysis of the problem: I'd reckon the event.altKey isn't being checked to handle brackets correctly. Just for the record, the event recorded that should be registering keyCodes 18+56 as [ and 18+57 as ] on the Finnish layouts with event.altKey being true. Problems may of course arise because we have no way of guessing if the user has Swedish or Finnish layout if his browser isn't set to one of these languages.
May 25, 2015
#19 tapani.k...@arcusys.fi
Is anything being done with this issue?

The problem blocks the next file function using the keyboard. The key can be used if focus is manually moved out of the diff view, but that defeats the purpose of the hotkey to begin with!

Even if this problem doesn't affect every user of gerrit, for those that are affected it blocks major functionality. (Also not like the affected user amount is minor either. This issue affects multiple whole countries). The next file function in diff view is the single most important hotkey when doing code review. The priority should not be minor.
May 26, 2015
#20 moigoo...@nic.fi
Agreed! This is Major.
Aug 3, 2015
Project Member #21 david.pu...@sonymobile.com
 Issue 3507  has been merged into this issue.
Aug 3, 2015
Project Member #22 david.pu...@sonymobile.com
 Issue 2643  has been merged into this issue.
Aug 5, 2015
#23 sven.sel...@sonymobile.com
To me it seems like CodeMirror is the culprit:
Possibly related to [1]

American keyboard seems to be assumed by CodeMirror.

---------------------
With Swedish keyboard
'[' - AltGr+8
']' - AltGr+9
---------------------
American - Swedish key equivalent
'['      - 'å'
']'      - '"'
----------------------
# In side-by-side view (using swedish keyboard, Gerrit: v2.11.1)

## With focus outside the code mirror box:
'[' and ']' navigates to previous and next file respectively
'å' and '"' does nothing

## With focus inside the code mirror box (when keys are pressed twice):
'[' and ']' navigates to top and bottom of file respectively
'å' and '"' navigates to previous and next file respectively

/Sven
Aug 5, 2015
#25 sven.sel...@sonymobile.com
Double sorry!
The key 'å' only needs to be pressed once.
The key '"' on a swedish keyboard is only written after another key is pressed which could explain why you need to press it twice to get it to work. Pressing '"' and then 'space' or any other key works equally well.

/Sven
Oct 22, 2015
#26 elegance...@gmail.com
I also have this issue after I switched to the Dvorak keyboard layout. The [] are on the top numeric keys and do not require holding Shift.
Propose to add an alternative hotkey for file switching, e.g. Shift+N/P or Alt+N/P
Sign in to add a comment

Powered by Google Project Hosting