My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1062: Intraline whitespace changes to a file are invisible
5 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by srhi...@google.com, Jul 20, 2011
What steps will reproduce the problem?
1. Upload patch with intraline whitespace changes within a single file only.
2. View diff for that file (other files can have different changes).

What is the expected output? What do you see instead?
No matter which settings/checkboxes are active, I cannot get it to show me the actual diff of the changelist. It always just shows the file information (i.e. nothing changed).

Take a look at https://android-git.corp.google.com/g/#patch,unified,122844,1,slang_rs_reflection.cpp for an example of how this appears. If you cherry-pick the change, you will see that this file has only intraline whitespace changes.

Jul 29, 2011
#1 mtennant@chromium.org
I believe I am seeing this on a chromium.org project as well:

http://gerrit.chromium.org/gerrit/#patch,sidebyside,4858,4,profiles/targets/chromeos/package.use.mask

Look at the last patch for this file (patch set 3 to 4).  One whitespace was removed at the end of line 5, but you can't see it.  You can only see it if you look at the difference from the base to patch sets 1, 2 or 3.  And then only if Ignore Whitespace is set to "Leading, At Line End" instead of "None" (which makes no sense).
If you set the Ignore Whitespace setting to 
Sep 5, 2012
#2 shwetan...@imaginea.com
i have noticed this in my project when a change from " a" to "a" was not shown by gerrit diff.
Sign in to add a comment

Powered by Google Project Hosting