My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2169: SideBySide2: 'f' key should open a popup with the list of files in the patch set
7 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by edwin.ke...@gmail.com, Oct 7, 2013
On the old diff screens it's possible to open a popup with a list of all files which have been changed in the patch set by pressing the 'f' key. This allowed fast navigation to specific files in the patch set. The new SidyBySide screen should support this feature too.
Nov 25, 2013
Project Member #1 edwin.ke...@gmail.com
 Issue 2276  has been merged into this issue.
Nov 25, 2013
Project Member #2 edwin.ke...@gmail.com
Actually I started to use 'u' instead which brings me up to the change screen where the file list is available.
Dec 13, 2013
#3 sop@google.com
Use 'u' to go up to change screen and select another file.
Status: WontFix
Dec 13, 2013
#4 florent....@intersec.com
I'm a bit disappointed that the review workflow is getting more complicated with the new change screen.

The file-list popup was very handy to have a quick look at what was being reviewed. Let me provide a small use case: you are reviewing some code that introduce a call to a function that you know is implemented in another file; that call does not seem correct so you want to rapidly check if the function has been altered or if the call is effectively invalid. In that case, having the file-list has a popup is quick, let you check if the file that hold the function has been modified or not, then either switch to the corresponding file (if it has been modified) or just put a comment about the misuse of the function (if it has not been modified). If you need to go back to the change screen every time you want to check something about the list of modified/reviewed file, you just create more context-switches in the head of the reviewer.

Sorry for the long description.
Oct 7, 2014
#6 TheMole...@gmail.com
I'd add my vote that it should be fixed. I frequently use the f key to check whether another file has been modified. If the other file has been modified I keep reviewing the current file from the place I am at, if it hasn't I add a comment in the current file at the place I am at. Using 'u' is horrendous in this place as it looses the position that you are at.
Oct 7, 2014
Project Member #7 edwin.ke...@gmail.com
Reopening this issue since there seems to be a lot of interest in this feature (see also discussion on mailing list [1]). Maybe one of the interested parties wants to implement this?

[1] https://groups.google.com/d/msg/repo-discuss/B8x91Oe7Ezo/gT0o0YaO0zYJ
Status: New
Sign in to add a comment

Powered by Google Project Hosting