| Issue 936: | publish comments, server error, empty key | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.6.1, 2.1.7-rc0 What steps will reproduce the problem? 1. Click Review 2. enter comments 3. Click Publish Comments or Publish and Submit What is the expected output? What do you see instead? Both functions "work", but, I get a strange message: Application Error Server Error Empty key Unfortunately, there is nothing in error_log, so I can't quite figure out what gerrit is failing on. Please provide any additional information below. I've setup gerrit with an HTTPS reverse proxy, but, have confirmed that the error appears even in regular HTTP mode without a proxy. Likewise, it doesn't make a difference between IE and Firefox. Any help is greatly appreciated.
May 16, 2011
#1
aaronlab...@gmail.com
May 16, 2011
adding screenshot
Jun 10, 2011
Same here!
Here is the JSON response
/gerrit/rpc/PatchDetailService
{"jsonrpc":"2.0","method":"publishComments","params":[{"changeId":{"id":2617},"patchSetId":1},"THE REVIEW BODY.",[{"categoryId":{"id":"CRVW"},"value":1}]],"id":14,"xsrfKey":"CENSORED"}
error: {code:-32603, message:Empty key}
id: 14
jsonrpc: "2.0"
Jun 10, 2011
Interesting ... makes me feel better that its just not me. That 32603 error almost looks like its SQL related? I wonder if this is a problem with the gerrit and MySQL integration... are you using MySQL as well?
Jun 10, 2011
upgraded to the latest and greatest, 2.2.1 -- issue still happens. it'd be great to get some kind of response/support for this from the gerrit development team.
Jun 10, 2011
Ok, we've fixed it here: - The bug was in the handling of CRAM-MD5 - The upgrade script from 2.1.6 added smtpUser to the [sendemail] section of the config (maybe my mistake? not sure) - with that it forced AuthSMTPClient to authenticate - there it fails and the exception bubbles up to the client Maybe the reason is that not smtpPass was configured Taking out the smtpUser from the config or setting enable = false solves the inconvenient UI issue. The former is better if you need the emails
Jun 10, 2011
sweet -- that did the trick (I removed smtpUser from the config). thanks so much! now I can at least use gerrit again to publish comments and not have the unfortunate UI issue. i might as well stick with version 2.2.1, although i'm certain the workaround would've probably solved earlier issues as well. will there be plans for a more permanent fix so that AuthSMTPClient won't authenticate if a password isn't set? |
|
| ► Sign in to add a comment |