My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3536: Manually added reviewers block approvals for labels in the range [0, +1]
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by emmanuel...@gmail.com, Aug 27, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11 branch (tested: 2.11.rc0 and 2.11.3)

What steps will reproduce the problem?

1. Add a new label in All-Projects:
[access "refs/heads/*"]
       label-Ready-to-Submit = 0..+1 group Registered Users
[label "Ready-to-Submit"]
       value =  0 Not ready to be submitted
       value = +1 Can be submitted
       copyMaxScore = true
2. Manually add a reviewer to a review.
3. Refresh the screen.

What is the expected output? What do you see instead?

The addition of the reviewer should not change the state of the review but it does.
The added reviewer blocks the review:
gerrit query --format=JSON --submit-records change:2
{..., "submitRecords":[{"status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"},{"label":"Verified","status":"NEED"},{"label":"Ready-to-Submit","status":"REJECT","by":{"email":"user2@example.com","username":"user2"}}]}]}

whereas we should have the same result as when a reviewer appears after posting a comment:
{...,submitRecords":[{"status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"},{"label":"Verified","status":"NEED"},{"label":"Ready-to-Submit","status":"NEED"}]}]}

Please provide any additional information below.

Version 2.10.6 works as expected.
Setting 'functionName=AnyWithBlock' leads to the same issue as the default value 'MaxWithBlock'.
A workaround is to use 'functionName=MaxNoBlock'.

Jan 8 (2 days ago)
#1 emmanuel...@gmail.com
Duplicate of #3574 that has been fixed in 2.11.4.
Sign in to add a comment

Powered by Google Project Hosting