My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3345: Preserve line-endings in inline editing
17 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----
Cc:  David.Os...@gmail.com


Sign in to add a comment
 
Reported by huebner....@googlemail.com, Apr 30, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11

What steps will reproduce the problem?
1. Edit one line of a file which has DOS style line-endings (\r\n) in the new inline-editor
2. publish the new change
3. All line-endings have been replaced by \n

What is the expected output? What do you see instead?

I would expect the line-endings of all lines to be preserved as is, that should be \r\n instead of \n. If new lines are added during inline editing, I would expect to set line-endings in the same style as preceding line-endings.

Please provide any additional information below.
Apr 30, 2015
#1 icee...@googlemail.com
Well, probably it should better respect the setting per repository, see e.g.
https://help.github.com/articles/dealing-with-line-endings/ for  a complete overview of what can be configured.
May 4, 2015
#2 huebner....@googlemail.com
Yep, you're right. It should respect the autocrlf settings.

In case autocrlf is set to false, however, the inline editor should not replace the line endings of the whole file.
Aug 18, 2015
#3 duft.mar...@gmail.com
we had the same issue on a rather large repository too. for us it is a no-go to change line endings, we'd need a fix for that :)
Aug 26, 2015
Project Member #4 david.pu...@sonymobile.com
 Issue 3467  has been merged into this issue.
Cc: David.Os...@gmail.com
Sign in to add a comment

Powered by Google Project Hosting