My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3324: Gerrit wrongfully ignores UI request to add missing group member(s) to review
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by marco.mm...@gmail.com, Apr 21, 2015
Affected Version: 2.10.2

What steps will reproduce the problem?
scenario; cf. dannorth.net/whats-in-a-story:

Given a gerrit group named 'us'
  And Alice part of that group
  And Bob also part of that group
  And a change C being reviewed
  And Alice already a +1-er for that change
  And Bob not added yet as reviewer for that change (C)
  And another user account with its email address starting with 'us'
When adding group 'us' as reviewer for change C in UI
Then gerrit wrongfully matches group 'us' and account with email starting with 'us'
  And gerrit invalidates that user wrongfully deemed as C reviewer candidate
  And gerrit (then) does not add group 'us' (i.e., missing Bob) as C reviewer.

What is the expected output? What do you see instead?
-Expected: Bob added as reviewer alongside Alice, in UI.
-Actual: no such addition; gerrit looks like ignoring the request in its UI.

Please provide any additional information below.
In the AccountResolver class, this code block starting at line 198 should maybe go away:
(..)
    for (AccountExternalId extId : schema.get().accountExternalIds()
        .suggestByEmailAddress(a, b, 10)) {
      result.add(extId.getAccountId());
    }
(..)
More tests and reviews would of course be needed prior to removing or changing code!

Addendum: if group name "matches" more than one account email prefix, the group (its missing members) *will* be added as reviewers.
/Marco M.
Sign in to add a comment

Powered by Google Project Hosting