My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3189: Prolog Cookbook: Describe better how to inherit submit rules
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by cam.sp...@solidfire.com, Feb 18, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.10

What steps will reproduce the problem?
1. Create a rules.pl file in All-Projects.git
2. See that it does not get run in projects that inherit All-Projects.git

What is the expected output? What do you see instead?

It's not clear from the documentation (https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html) that rules.pl does not get inherited as project.config does.

I think that projects should inherit rules.pl from their parents in the same way that they inherit project.config (this would be easier to manage, and seems more intuitive to me).

If that's not possible, it should be clear in the documentation that they don't inherit.


Please provide any additional information below.

Feb 18, 2015
Project Member #1 edwin.ke...@gmail.com
Submit rules apply only to the current project, if you want inheritance you must implement a submit filter as described in [1].

[1] https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html#SubmitFilter
Feb 19, 2015
#2 cam.sp...@solidfire.com
I see, thank you!

I still think that this could be more clear in the documentation though, should I try to open a new issue/request on that or could this issue be used to track that?
Feb 19, 2015
Project Member #3 edwin.ke...@gmail.com
We can use this issue, I've adapted the issue summary.
Summary: Prolog Cookbook: Describe better how to inherit submit rules (was: rules.pl is not inherited from All-Projects)
Sign in to add a comment

Powered by Google Project Hosting