My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3087: Comments attributed to Patch Set 0 and not shown
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by ruhler@google.com, Jan 5, 2015
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.10-rc1-995-g82a4db4

I added some comments to the code, then pressed 'reply' and 'post' to post the comments. The history shows my post as 'Patch Set 0: (3 comments)', but does not show any of the comments. The comments also do not appear where I put them in the code.

Why did the comments get attributed to 'Patch Set 0' instead of 'Patch Set 1' as expected? Why are the comments not visible? Is there any way to recover the comments?

The relevant change: https://android-review.googlesource.com/#/c/121451/

Some history on the change, in case it is relevant:
1. I created and uploaded a change (https://android-review.googlesource.com/#/c/121261/).
2. I rebased the change in my own directory to a later commit.
3. I repo uploaded my re-based change.
This created an entirely new change list (121451) instead of adding a patch set to the original change like I was expecting it to.
4. I abandoned the original change (121261).
5. I edited the commit message for the new change (121451) to include the "Change-Id: " line using the gerrit web interface. I'm not sure why the commit message didn't already contain a Change-Id line.
6. I opened all files diff against base, reviewed files, added three comments and posted them as described above.

Note that this change is dependent on another change (https://android-review.googlesource.com/#/c/121224/) that I also rebased manually and separately from this change.

See screenshot for the display of the history where comments are not shown.
screenshot.png
69.2 KB   View   Download
Sign in to add a comment

Powered by Google Project Hosting