My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3006: Warn about configurable comment links with the same name
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by sbel...@google.com, Nov 5, 2014
Affected Version: v2.10-rc0-861-ga026116

What steps will reproduce the problem?
1. Have a config for gerrit which looks like this:
[commentlink "exactname"]
  ...
[commentlink "exactname"]
  ...

What is the expected output? What do you see instead?
Expected: As I made an obvious mistake, I want to get warned about the miss configuration.
Actual output: The last section with the subsection name is used for configuring the commentlinks.

Please provide any additional information below.
I am not sure if this to be fixed near the comment link processing or if this behavior is inherited from the git config file format.


Nov 5, 2014
#1 dborowitz@google.com
IIRC it's valid to say:

[section]
 value = foo
[othersection]
 ...
[section]
 value = bar

and this is equivalent to:
[section]
 value = foo
 value = bar
[othersection]
...

And config.getString("section", null, "value") would return bar in both cases.

I think the thing you want to warn about is when there are multiple of any of the recognized keys of the commentlink section.
Sign in to add a comment

Powered by Google Project Hosting