My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2883: Reviewed Incoming reviews still highlighted
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by sam.bett...@gmail.com, Sep 3, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8.4-15-g6dc8444

What steps will reproduce the problem?
1. Have some incoming reviews
2. Review the incoming reviews
3. Return to My > Changes page

What is the expected output? What do you see instead?
Expected result is once reviewed the row in the table is no longer highlighted until a change is made. 
What I actually see is some reviews get left highlighted, whether they are reviewed or not. 

Please provide any additional information below.

This seems intermittent and seems to be down to an issue with these lines:

/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java

389     final Element tr = DOM.getParent(fmt.getElement(row, 0));
390     UIObject.setStyleName(tr, Gerrit.RESOURCES.css().needsReview(), !haveReview
391         && highlightUnreviewed);

Sign in to add a comment

Powered by Google Project Hosting