My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2468: Commiter/non commiter indicator
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by rlu...@google.com, Feb 12, 2014
When displaying the list of patches, it would be very useful to have an indicator for whether the author has commit rights or not (maybe color code the author name or add an indicator besides it).

Our projects has many contributors, some have commit rights and some not. Normally we leave to the authors to merge their patches but if they don't have commit rights then the +2 reviewer (who normally has commit access) will merge the patch.

In the current situation many patches are left unmerged due to the +2 reviewer not noticing lack of commit access of the author.
Feb 16, 2014
Project Member #1 david.pu...@sonymobile.com
We could possibly add this in the tooltip that is shown when the mouse is hovered over the reviewer's name in the change screen.

On the other hand, we may want to wait until that information is migrated into a proper popover dialog that is shown along with the user's avatar and other useful information.

I think adding a mark or highlighting the user's name in a different colour might make the screen look a bit too cluttered (than it already is).

Feb 18, 2014
#2 rlu...@google.com
I agree that using colors will be too cluttered; and I still find the color and size indicator for size of changes unnecessary clutter, IMHO it should be either color or bar size (anyway I use the numbers in my view).

But I think underlining (or bold or italics) authors with commit access won't.  
Sign in to add a comment

Powered by Google Project Hosting