My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2410: side-by-side diff mode does not wrap long lines
21 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by Mark.J.A...@gmail.com, Jan 20, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Use gerrit 2.8.1
2. View a "side-by-side diff" of a file with a line that is longer than a magic number of characters (e.g. https://gerrit.gromacs.org/#/c/3001/1/src/contrib/fftw/CMakeLists.txt,cm)

What is the expected output? What do you see instead?

I expected the diff output to wrap lines, like it does in "unified diff" mode. Instead, the line is truncated.

Jan 21, 2014
#2 Mark.J.A...@gmail.com
The symptoms are probably related to https://code.google.com/p/gerrit/issues/detail?id=2351, but the fix is not to have two independent horizontal scrollbars for two side-by-side diffs, because those scrollbars are not synced. Even synced horizontal scrollbars are problematic if the long line is present in only one diff, or of different or extreme length, etc.

A long line in a side-by-side diff should be wrapped if longer than the available space.
Feb 27, 2014
#3 brianjmu...@gmail.com
And relatedly (perhaps this is fodder for a new ticket even) the width of the panes in side-by-side mode should not max out at some arbitrary value beyond which the panes stop expanding and I only get more whitespace on the right side of the browser window.
Feb 27, 2014
#4 brianjmu...@gmail.com
In fact, is there any reason this issue is not just a duplicate of  issue #2351 ?
Sign in to add a comment

Powered by Google Project Hosting