| Issue 2097: | Non-votable categories returned by submit rules appear in web interface | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.6.1
What steps will reproduce the problem?
1. Created a Prolog submit rule that returns a label('Not-RFC-or-WIP', need(_)) (tried with a lot of different combinations of rules and return values, but not very simple rules). The project does not have this label configured as a votable label.
2. Reload the Gerrit front page. An extra column appears for this label, but is empty for all changes.
3. Open a change that for which the submit rule returns this label and where there are reviewers. The table with the reviewers has this extra column, grayed out.
What is the expected output? What do you see instead?
According to the Prolog cookbook, only those labels that are configured in the project should appear as votable. Expected output is that there is only a "* Need Not-RFC-or-WIP" for affected changes (this does appear correctly), but otherwise the web interface would stay the same.
If the submit rule returns the label(..., ok(_)) for those changes where it doesn't return need(_), then the extra category appears in the reviewers table for all changes. If the label is only returned for some changes, then the extra category appears only for those changes.
It doesn't make a difference whether the labels are explicitly configured for the project or are inherited from All-Projects.
Sep 2, 2013
Project Member
#1
david.pu...@sonymobile.com
Cc:
bruce.zu@sonymobile.com
|
|
| ► Sign in to add a comment |