My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1786: Diff highlights wrong character
7 people starred this issue and may be notified of changes. Back to list
Status:  AwaitingInformation
Owner:  ----


Sign in to add a comment
 
Reported by krinklemail@gmail.com, Feb 12, 2013
Affected Version: 2.5.2-1277-gca0bdda

What steps will reproduce the problem?
1. View the diff of a change with only whitespace changes on a certain line (there can be non-whitespace changes in the same diff, but not on the same line) 
2. Set preference "Ignore Whitespace: None" and apply it

What is the expected output?

The space is highlighted in the stronger color.

What do you see instead?

A random other character that wasn't changed is highlighted.
The changed whitespace is not highlighted.


Please provide any additional information below.

The diff content is correct, which makes it easy to verify this bug by looking at the attached screenshot and looking at the two sides. The highlighted character clearly hasn't changed, and the spaces between $foo = and the value have changed but aren't highlighted.
gerrit-ws-bug.png
114 KB   View   Download
Sep 19, 2013
#1 Urio...@gmail.com
I have a very similar issue in 2.6.1.

If there are whitespace changes on sequential lines, the whitespace that has changed in the first line is correctly highlighted. For all the lines that follow, the first character on the line is highlighted and the changed whitespace is not.
gerrit_whitespace_error.png
30.4 KB   View   Download
Nov 28, 2013
#2 j...@kallwies.com
I have the same problem in 2.7!
Gerrit_SpaceDrawingBug.png
30.1 KB   View   Download
Mar 19, 2015
#3 ejsand...@gmail.com
Still seeing this is 2.8.1
Jul 2, 2015
Project Member #4 edwin.ke...@gmail.com
Does this still happen with the new side-by-side diff screen which is based on CodeMirror?
Status: AwaitingInformation
Sign in to add a comment

Powered by Google Project Hosting