| Issue 1511: | Comment notification email has broken subject | |
| 2 people starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: 2.3 What steps will reproduce the problem? 1. A user (in this particular case it was Jenkins) sends a review comment 2. Change owner receives a notification email What is the expected output? What do you see instead? Notification email was received with the subject: Comments - project[branch]: #elipses(60, $change.subject) "#elipses(60, $change.subject)" is shown instead of the actual change subject. Please provide any additional information below. In the subject mentioned above I have replaced the actual project and branch names with "project" and "branch".
Aug 6, 2012
#1
david.pu...@gmail.com
Oct 22, 2012
I suspect that this is a problem with customised templates on our installation.
Status:
Invalid
Oct 26, 2012
Re-opening this. It occurs sometimes with the customised templates in [1] but it's still not clear if it's a problem in the templates or in Gerrit itself. [1] https://gist.github.com/1869609
Status:
New
Oct 26, 2012
Ok. I have done some digging and I'm very sure that this is due to a threading issue in velocity that affects among other versions 1.6.4 (which we are running). https://issues.apache.org/jira/browse/VELOCITY-776 I guess we could get around it by removing the following line in VerlocityRuntimeProvider.java: p.setProperty(RuntimeConstants.VM_PERM_INLINE_LOCAL, "true"). Not sure if that would do any damage to other templates. I have submitted a Change RFC here: https://gerrit-review.googlesource.com/#/c/38921/ |
|
| ► Sign in to add a comment |