My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1270: Support for displaying code-freeze status when submitting
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by jonatan....@softhouse.se, Feb 24, 2012
Hi,

I'm working with a company that has an old-fashioned approach and still emails out warnings when there's code freezes.

I wonder if it would be desirable to display this in the window when people submit? Or is this against the usual git procedures?

I prototyped a solution without implementing any logic for checking the code-freeze status but in the screenshot the general intent can be seen.

Maybe the code-freeze status could be set with:
https://code.google.com/p/gerrit/source/browse/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java
?

Maybe the button could become red as well?


Code-Freeze-Warning.png
82.0 KB   View   Download
gerrit_warn_for_code_freeze.patch
2.9 KB   View   Download
Feb 24, 2012
Project Member #1 nas...@codeaurora.org
Hmm, this seems like something we'd want to allow customization of via the prolog engine and perhaps arbitrary label support. You'd apply a "frozen" label to all changes? projects? project/branch combo? and then the prolog engine would either disallow or require an override for submitting?
Feb 28, 2012
#2 jonatan....@softhouse.se
In our case it's the project/branch combo that's wanted. I would assume that would be the most used combo. The solution you suggest seem to be pretty good as it would be general enough and pretty configurable. Would it be hard to implement? I'm not that familiar with prolog so help in that department would be greatly appreciated.
Sign in to add a comment

Powered by Google Project Hosting