My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 598: Option to Reject push's with branch push +1 privileges, if the commits are in Gerrit already and not reviewed +2
3 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by antony.s...@gmail.com, Jun 15, 2010
Conversation:
A push to a branch (via the Push Branch +1 or
higher permission) overrides the approval process altogether.  But it
still updates the change records, if they exist for the corresponding
commits.

Its an open feature request to permit push branch, but require the
approval bits to be set.

> Yeah, that'd fix it. And clue which issue # it is?

No clue.  It may have just been part of a comment on another issue,
which I can't find right now.  Please feel free to open a new feature
request for it.  I know its a desired feature, I know its been asked
for, I just can't find where it was previously discussed.  :-(
Jun 15, 2010
#1 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Jun 16, 2010
#2 nas...@chromium.org
@antony.stubbs
I don't think we want to change the behavior when +1 Push Branch is granted (we should allow users with this perm to push regardless of approval status). I think we'd like to change behavior when Submit +1 is granted such that it will allow a push to refs/heads/* if the commit(s) you are pushing are already approved/verified/etc.

If that sounds correct to you, I'll change the summary to:
Allow push to refs/heads/<branchname> when push will close a change that is approved/verified/etc and for which the pushing user has Submit +1 permission.
Jun 16, 2010
#3 antony.s...@gmail.com
Well _this_ issue is definitely about +1 Push permission. I'm pretty sure there are some people that want this, me included. 

Maybe there could be a +1.5 which lets you push regardless of review status. But that would also just be covered by the 
[x] Allow +1 Push regardless of review status of existing changeId's.

Feel free to create a new issue relating to +1 Submit permissions in regards to review.

So in summary, that's a no. :)
Sign in to add a comment

Powered by Google Project Hosting