My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 357: changes don't close if tagged
4 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  sop@google.com


Sign in to add a comment
 
Project Member Reported by sop@google.com, Dec 12, 2009
Affected Version: 2.1.0

What steps will reproduce the problem?
1. Upload a new change.
2. Create an annotated tag which points at the change's commit.
3. Push the annotated tag to the repository.
4. Submit the uploaded change.

What is the expected output? What do you see instead?

The change should be marked as merged, and the branch updated to point
to the change's commit.

Instead what happens is the change gets stuck in the SUBMITTED state,
but the branch was still updated.

An administrator has to manually update the database to fix the change:

  update changes set open='N',status='M'
  where change_id in (12873,12872);
  
  update patch_set_approvals set change_open='N'
  where change_id in (12873,12872);

Sign in to add a comment

Powered by Google Project Hosting