My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2872: GitHub plug: anonymous browsing of web interface not supported
2 people starred this issue and may be notified of changes. Back to list
Status:  AwaitingInformation
Owner:  ----


Sign in to add a comment
 
Reported by matt...@unsolvable.org, Aug 28, 2014
I'm running a fresh install of Gerrit master+GitHub, downloaded from http://ci.gerritforge.com/job/Gerrit-master-github/.

(Background: This includes a path which allows Gerrit to use GitHub OAuth for authentication. Patch is https://gerrit-review.googlesource.com/57570)

I'm able to authenticate with GitHub quite nicely, but one annoyance is that anonymous browsing appears to be disabled.

If I go to my Gerrit's home page, then Gerrit straight away redirects to GitHub:
* If I am not currently signed in to GitHub, I am prompted to sign in. I cannot proceed without signing in to GitHub.
* If I am already signed in to GitHub, GitHub passes back to Gerrit, at Gerrit indicates that I am logged in to it.

What I want: Gerrit should only request GitHub to authenticate when a user clicks "Sign In" on the Gerrit home page. Otherwise, for a user to browse my Gerrit, that *must* have a GitHub id, and that ends up in my Gerrit database.

Thus, the GitHub auth should work the same as the OpenID auth (if I remember that correctly).

Sep 8, 2014
Project Member #1 David.Os...@gmail.com
I am assuming that you are referencing to this change [1].
This works as expected, but the right configuration to achive that is somehow hidden. This should do what you want.

  [auth]
     type = OAUTH_GITHUB
     httpHeader = GITHUB_USER
     loginUrl = /login

[1] https://gerrit-review.googlesource.com/57570
Status: AwaitingInformation
Sign in to add a comment

Powered by Google Project Hosting