My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2798: Gerrit 2.9 init installs Verified Label
2 people starred this issue and may be notified of changes. Back to list
Status:  AwaitingInformation
Owner:  ----


Sign in to add a comment
 
Reported by berthami...@gmail.com, Jul 25, 2014
We upgraded from Gerrit 2.8.3 to Gerrit 2.9 (via 2.9.rc2) and suddenly our code reviews were blocked waiting for a verify step. We found that Gerrit had added an extra label that wasn't there in 2.8 and might be a regression.

Author: Gerrit Initialization <init@gerrit>
Date:   Mon Jul 21 09:30:09 2014 +0100

    Configure 'Verified' label

+[label "Verified"]
+       function = MaxWithBlock
+       value = -1 Fails
+       value =  0 No score
+       value = +1 Verified

Note that we were on 2.9.rc2 for some time testing interaction with its-jira which appeared fine. After upgrading however its-jira stopped working which may be related as the very next commit in the All-Projects history was todo with jira initialisation 

 [plugin "its-jira"]
        enabled = true
+       branch = refs/heads/*
 [label "Verified"]
        function = MaxWithBlock
        value = -1 Fails
-       value =  0 No score
+       value = 0 No score
        value = +1 Verified

Jul 28, 2014
Project Member #1 David.Os...@gmail.com
It works as expected. During init phase (in your case during upgrade phase) there is InitStep that installs Verify label. Apparently you have answered the question for 'Y'. That why you see the commit n refs/meta/config branch. If you don't want Verify label, just remove [label "Verified"] section from project.config.
Status: AwaitingInformation
Sep 2, 2014
#2 Jonh.Kel...@gmail.com
I've faced similar problem, folks.
Yesterday I've upgraded gerrit from 2.8.5 to 2.9. IIRC installer didn't ask me about installing labels.
Now that's the issue: user cannot submit a change.
On Change Screen I see 
  - "Change NNN - Needs Verified" at the top-left
  - "Code-Review +2 Verified" below the right pane
  - no UI to verify (because no one has permission on Label Verified)

First I added permission on Label Verified (to make users happy), then removed that label at all (to make them very happy:)).

All's well that ends well.
That's it 
Jan 5 (5 days ago)
#3 khadepra...@gmail.com
How to get official mark on insta

Sign in to add a comment

Powered by Google Project Hosting