My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2647: Ctrl+C does not work on new change screen
2 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by fraczwoj...@gmail.com, May 9, 2014
Affected Version: 2.8.4

What steps will reproduce the problem?
1. Open change details in new change screen
2. Open "revisions" dropdown
3. Select commit hash of the opened patchset (the one that is not a link)
4. Press Ctrl+C

What is the expected output? What do you see instead?
I expect the hash to be in my clipboard. It is not. I have to right click it and choose "Copy" to copy it.

Please provide any additional information below.
Problably the Ctrl+C shortcut is handled by Gerrit and does not copies the content to clipboard.
May 12, 2014
Project Member #1 David.Os...@gmail.com
Indeed. Work around would be to use right mouse click "Copy". Tested in Safari and it works.
Status: AwaitingInformation
May 12, 2014
#2 fraczwoj...@gmail.com
As I wrote - right click & copy works for me too.
May 13, 2014
Project Member #3 dougk....@gmail.com
It looks like this affects actually all keystrokes (closing the window, or using the "u" to go up to the dashboard both fail), and I tested in Chrome and Safari for Mac with the same results.
May 13, 2014
Project Member #4 dougk....@gmail.com
Okay, this happens because the PopupPanel is modal, and because the key press events aren't handled by the panel, they are cancelled.  To test this, change RightSidePopdown's show() method to create the PluginSafePopupPanel(true, false) -- this will create it with autoHide and NOT modal, and the copy will work normally.

Not sure if this is the "fix" -- but it certainly confirms the cause.
Sep 8, 2015
Project Member #5 dougk....@gmail.com
Looks like this might've been fixed in GWT.  Other keystrokes (such as "u" to go back to the dashboard) still don't work, but copy/paste seem fine.
Status: Accepted
Sign in to add a comment

Powered by Google Project Hosting