| Issue 2413: | Better error message in case of pushing several commits in which one is not signed | |
| 2 people starred this issue and may be notified of changes. | Back to list |
I unintentially tried to pushed several commits to Gerrit and got the error message that the commit was not signed (see below). Would it be possible to include the message that several commits are pushed to make it easier to see such an error? --------------------- Repository ssh://lvogel@git.eclipse.org:29418/jdt/eclipse.jdt.ui.git The contributor must "sign-off" on the contribution. Processing changes: refs: 1 Processing changes: refs: 1, done ---------- Reviewing commit: commit 1e900a3f2bb70429f8b3514d454350202527b2dd 1389989640 ----sp Authored by: Lars Vogel <Lars.Vogel@gmail.com> The author is not a committer on the project. The author has a current Contributor License Agreement (CLA) on file. error: The author has not "signed-off" on the contribution. Please see http://wiki.eclipse.org/CLA --------------------
Jan 21, 2014
Project Member
#1
david.pu...@sonymobile.com
Summary:
Better error message in case of pushing several commits in which one is not signed
(was: Better error message in case of pushing several commits in which on is not signed)
Jan 21, 2014
The message shown in the report is not from core Gerrit. Is the Eclipse.org Gerrit server running a commit validation plugin?
Jan 21, 2014
(No comment was entered for this change.)
Status:
AwaitingInformation
Jan 21, 2014
The eclipse.org Gerrit server uses a commit validation plugin (https://github.com/waynebeaton/gerrit-cla-plugin) to determine if a commit message contains the "signed-off-by" field and that the author is part of a cla signed group. Would Gerrit's API be sending to the plugin a list of commits to validate against? or does it send commits for validation one at a time to the plugin?
Jan 21, 2014
Commits are sent one-and-a-time by the Gerrit. As soon as we reject a commit, the process stops. I'm not aware of a means by which we can know that multiple commits are being reviewed. Is there an additional callback that we can tap into? FWIW, I've been stumped by this myself a few times. The best advice I can give is to be mindful of the commit's id.
Jan 21, 2014
Why are you using custom plugins to verify signed-off-by and CLA membership? Gerrit supports both of those checks out-of-the-box. Anyway, yes, commits are sent to the validation listener one at a time. If one of them fails (listener raises a validation exception), the push is aborted. The validation listener can return a list of validation messages, which may have the error flag set, but that will not cause the upload to be rejected. It will only cause the console to display something like: remote: error: (E) b9f09ec remote: error: (E) cbacc03 remote: error: (E) 07b4332 Perhaps it should be modified to reject when error messages are returned? |
|
| ► Sign in to add a comment |