| Issue 2934: | Diff view hides underscores in Firefox | |
| 9 people starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: 2.10-rc0-573-gc8c17ec and earlier at least to 2.8.6.1. What steps will reproduce the problem? 1. Open https://gerrit-review.googlesource.com/#/c/47736/11/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_66.java,cm in the browser What is the expected output? What do you see instead? Code is missing underscores, turning `Schema_66` into `Schema 66` for example. See the attached screenshot. Please provide any additional information below. I have tested this on Ubuntu 14.04 with GNOME 3.8, running Firefox 32.0.3. The problem is not present in the latest Chromium on the same OS. I can see the underscores if I zoom in two times in Firefox, so it seems the line height is just a bit too small. The font used by Firefox for the diff is DejaVu Sans Mono. This is probably related to issue 1734 , though it happening does not depend on the diff on that line.
Sep 28, 2014
#1
mikko.ah...@vincit.fi
Oct 10, 2014
I could fix this for Gerrit 2.9.1 and Firefox 32 on Ubuntu by applying this custom CSS:
.com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-difftable .CodeMirror pre {
padding: 0px 0px 2px;
}
Oct 16, 2014
Can reproduce, can confirm the custom CSS works as a workaround.
Apr 1, 2015
I can also confirm this CSS workaround, maybe it should be merged into gerrit |
|
| ► Sign in to add a comment |