My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1707: Using set-reviewers with change number fails
4 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by saxo...@gmail.com, Dec 6, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Push a commit to create a new change
2. gerrit query to retrieve the change number
3. Attempt to set reviewer by change number

What is the expected output? What do you see instead?

cmd-set-reviewers.html says:

"Changes should be specified as complete or abbreviated Change-Ids such as Iac6b2ac2. They may also be specified by numeric change identifiers, such as 8242 or by complete or abbreviated commit SHA-1s."

We expect a successful review set based on the change number. Instead, we get 'fatal: "$number" matches multiple changes' or 'fatal: "$number" no such change'. 

Please provide any additional information below.

We are trying to use change number because it's not possible to uniquely identify a change by commit id or change id. I am going to file a separate feature request about that. 
Mar 20, 2014
#1 mav...@cpqd.com.br
This issue still happens on Gerrit 2.8.1:

... gerrit set-reviewers --project <project> --add <user> 27147

fatal: "27147" matches multiple changes

Note: there's only one "27147" change in DB.
May 13, 2014
#2 mav...@cpqd.com.br
This issue happens when there is an abbreviated sha1 commit (in another change) which matches the change number, for example:

Change number = 27147
Commit sha1 = 27147f02927d0a1102d45ad5ed2bee1212e8c29d

We're now using the full commit instead of the change number in the "gerrit set-reviewers" command.

Mar 27, 2015
#3 lujing....@gmail.com
This make sense, maybe we should not support so SMART on change-Id, CL number, or SHA of commit. ;)

use Change-Id, as it show in stream-events.
Mar 27, 2015
#4 marceloa...@gmail.com
Actually the Change-Id has the same issue because we can have the same Change-Id used in multiple changes. The full Commit-Id is the only way to address this issue.
Sign in to add a comment

Powered by Google Project Hosting