My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1696: Meaningless dependencies
4 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by annu...@gmail.com, Nov 30, 2012
Affected Version: 2.5

What steps will reproduce the problem?
1. Create new branch from master, make a commit, and push it to refs/for/master

What is the expected output?

Commit should have no dependencies

What do you see instead?

I see previous commit in origin/master as dependence, marked as (MERGED)
Nov 30, 2012
Project Member #1 bklarson@gmail.com
This is expected behavior.  Your commit *does* depend on its parent commit... the parent has been merged already, so we mark it as such and Gerrit won't show the dependency unless you expand the box.
Status: WontFix
Nov 30, 2012
#2 annu...@gmail.com
Personally I wouldn't expect this behavior. Seeing links to changes which don't need review does not make much sense.
Nov 30, 2012
Project Member #3 bklarson@gmail.com
Looking into this a bit more - I'm wrong, there are definitely cases where we don't list any dependencies for changes.  I'm not sure what logic is used to determine when to add a change to the dependencies box.
Status: New
Nov 30, 2012
#4 sop@google.com
If you depend on a merge commit made by Gerrit, we don't have a change that exactly matches that SHA-1 so we have no dependency record to show.
Nov 30, 2012
#5 annu...@gmail.com
We use cherry-pick strategy, so there are no merge commits at all.
Nov 30, 2012
#6 annu...@gmail.com
BTW, this is a regression^W behavior change introduced after 2.4.2
Nov 30, 2012
#7 sop@google.com
Remain on 2.4.2 if you don't want changes?
Nov 30, 2012
#8 annu...@gmail.com
I have nothing against changes. I just don't want changes which decrease usability.
Dec 14, 2012
#9 ygorsh...@smartlabs.tv
This behavior is confusing when you try to explain why there is a dependency on something you had merged already.
Jul 15, 2013
#10 annu...@gmail.com
ping
Sign in to add a comment

Powered by Google Project Hosting