My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1097: Gerrit sends too many emails, it would be better if the submitter could control this
42 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by vbendeb@chromium.org, Aug 18, 2011
Gerrit sends way too many emails. For instance, one submits a change for reviw. Then adds a reviewer, and sets the 'verified' bit. Three emails are generated, and then one extra per reviewer (if there are more reviewers), just from the get go.

If the user uploaded a patch but is not yet ready to submit it for review (for whatever reason, say she wants to look at the side by side diffs), people subscribed for the repository updates get the email immediately.

Or, say, the user sets the 'verified' bit and then clicks on the 'submit' button. Two emails are sent.

It would be better if the emails generation was controlled by the users submitting a change for review or reviewing the change, and the automated email generation was limited to only the 'change merged' event.

Aug 22, 2011
#1 vben...@gmail.com
On top of that, in case a person comments on a change submitted to one of his watched project, two identical emails are sent to that person.
Nov 29, 2011
#2 rol...@rschulz.eu
Another instance: Maybe users don't want to receive messages when the auto-build system verifies the change-set. So it would be nice to be able to filter mails on either the user (who did the review) or the type (review/verify) or be able to specify for the cmd-line approve that it this approve shouldn't send an email. 
Nov 29, 2011
Project Member #3 edwin.ke...@gmail.com
You already can configure that the messages that are triggered by an auto-build system are not send to everyone, but only to the change owner. For this you need to have a Gerrit group that contains the user of the auto-build system, go to the group options in the Gerrit WebUI and select the checkbox for 'Authors' under 'Send email notifications about comments and actions by users in this group only to:'.
Nov 29, 2011
#4 rol...@rschulz.eu
You are right. I didn't know about this option.
Feb 7, 2012
Project Member #5 bklarson@gmail.com
 Issue 1250  has been merged into this issue.
Jul 24, 2012
#6 Sc...@lavenderphoto.com
I do not see this option under 'Authors' for my CI systems group.

We have two Jenkins jobs that repsond to uploads to Gerrit for validation. When a user uploads a change, three emails are sent. Two, one for each validation task starting, and one final email that consolidates the results from these two jobs. How can I prevent the start emails? The OpenStack Jenkins only sends the final results email. How do they accomplish this? 
Jul 24, 2012
Project Member #7 edwin.ke...@gmail.com
This setting cannot be done on groups anymore. Instead it is now a global capability [1] that can be assigned on the 'All-Projects' project.

[1] https://gerrit-review.googlesource.com/Documentation/access-control.html#capability_emailReviewers
Mar 29, 2013
#8 presich....@gmail.com
Is there any possibility to deny CI systems to send email to Author too?

As I understand Email reviewers option deny sending email to Reviewers only.
Apr 1, 2013
Project Member #9 edwin.ke...@gmail.com
> Is there any possibility to deny CI systems to send email to Author too?
With Gerrit 2.6 CI systems can control to whom email notifications should be send. To do this they need to use the REST API to post comments [1] and set the 'notify' field in the ReviewInput [2].

[1] http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/rest-api-changes.html#set-review
[2] http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/rest-api-changes.html#review-input
Nov 15, 2013
#10 presich....@gmail.com
But still there is no option to configure sending emails to the authors of the commit, right?
Authors receives email on every comment to the change?
Nov 15, 2013
Project Member #11 edwin.ke...@gmail.com
When you post a review via the REST API you can control to whom emails should be send [1]. Pay attention to the 'notify' field in the ReviewInput [2]. In the new ChangeScreen there is a checkbox whether to send emails or not.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-review
[2] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#review-input
May 8, 2014
#12 sajjad.r...@gmail.com
Is there anyway to block auto build messages with some Jenkins plugin ideally? As we want to get email for failures in autobuild but not for success for example. Also is there anyway to send only one email when all ~20 autobuilds are successful for one change?
May 8, 2014
#13 sajjad.r...@gmail.com
We don't use REST API as far as I can tell. We use git commands git add, cmmmit etc.
Sep 2, 2014
#14 tsuna...@gmail.com
When someone reviews a change and submits it, Gerrit sends two separate emails.  If the change fails to merge, additional emails are also sent.
Jan 9, 2015
#15 vbendeb@chromium.org
guys, is there any chance this issue is given a higher priority? It's been sitting there well into the fourth year now.

What happens is that when there are large stacks of patches in flight, and the author uploads a new stack, every patch triggers and email to every reviewer, even though many of the patches might be still not ready for review.

I myself often use gerrit as a means of just looking at my changes in a convenient side by side interface, and upload patches a few times before they are ready. I know others do too.

And each such upload triggers emails, and then people start looking at half baked patches and commenting on them.  Or, even worse, stop paying attention to the flood of emails coming from gerrit and need to be pinged separately to start looking at the changes.

This is is a huge productivity sink, is you had a dollar each time I heard someone bitching about it, you would be much wealthier than you are now.

Can it be changed such that the user and the group can set their email generation preferences? I think the only email should be sent when the user checks the "verified" box, and then for reviews/approvals.

Each patch update should not trigger an email to all involved, only remove the approval, if there is a code change. 

Do you think this is acceptable in principal? Why not, if you do not? What is preventing this from happening if you think this is acceptable?

Jun 17, 2015
#16 izek...@gmail.com
When this will be fixed??
Jun 23, 2015
#17 wznoin...@gmail.com
"affects me" too
Sign in to add a comment

Powered by Google Project Hosting