My favorites
▼
|
Sign in
gerrit
Gerrit Code Review
Project Home
Downloads
Wiki
Issues
Source
Export to GitHub
New issue
Search
Search within:
All issues
Open issues
New issues
Issues to verify
for
Advanced search
Search tips
Subscriptions
Issue
639
attachment: 0001-Get-Ctrl-s-Ctrl-d-kinda-working-in-Google-Chrome.patch
(3.3 KB)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
From 9f265d2961fe31090b2fcd0b581e3257383f754c Mon Sep 17 00:00:00 2001
From: japearson <japearson@agiledigital.com.au>
Date: Tue, 27 Jul 2010 19:22:23 +1000
Subject: [PATCH] Get Ctrl-s Ctrl-d kinda working in Google Chrome
---
.../gerrit/client/patches/CommentEditorPanel.java | 41 ++++++++++----------
1 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java
index 4d3022d..bef8374 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java
@@ -23,8 +23,8 @@ import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.DoubleClickEvent;
import com.google.gwt.event.dom.client.DoubleClickHandler;
import com.google.gwt.event.dom.client.KeyCodes;
-import com.google.gwt.event.dom.client.KeyPressEvent;
-import com.google.gwt.event.dom.client.KeyPressHandler;
+import com.google.gwt.event.dom.client.KeyDownEvent;
+import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Timer;
import com.google.gwt.user.client.Window;
@@ -80,10 +80,10 @@ public class CommentEditorPanel extends CommentPanel implements ClickHandler,
text.setCharacterWidth(INITIAL_COLS);
text.setVisibleLines(INITIAL_LINES);
DOM.setElementPropertyBoolean(text.getElement(), "spellcheck", true);
- text.addKeyPressHandler(new KeyPressHandler() {
+ text.addKeyDownHandler(new KeyDownHandler() {
@Override
- public void onKeyPress(final KeyPressEvent event) {
- if (event.getCharCode() == KeyCodes.KEY_ESCAPE
+ public void onKeyDown(final KeyDownEvent event) {
+ if (event.getNativeKeyCode() == KeyCodes.KEY_ESCAPE
&& !event.isAnyModifierKeyDown()) {
event.preventDefault();
if (isNew()) {
@@ -96,22 +96,21 @@ public class CommentEditorPanel extends CommentPanel implements ClickHandler,
if ((event.isControlKeyDown() || event.isMetaKeyDown())
&& !event.isAltKeyDown() && !event.isShiftKeyDown()) {
- switch (event.getCharCode()) {
- case 's':
- event.preventDefault();
- onSave(NULL_CALLBACK);
- return;
-
- case 'd':
- event.preventDefault();
- if (isNew()) {
- onDiscard();
- } else if (Window.confirm(PatchUtil.C.confirmDiscard())) {
- onDiscard();
- } else {
- text.setFocus(true);
- }
- return;
+ if ("S".codePointAt(0) == event.getNativeKeyCode()) {
+ event.preventDefault();
+ onSave(NULL_CALLBACK);
+ return;
+ }
+ else if ("D".codePointAt(0) == event.getNativeKeyCode()) {
+ event.preventDefault();
+ if (isNew()) {
+ onDiscard();
+ } else if (Window.confirm(PatchUtil.C.confirmDiscard())) {
+ onDiscard();
+ } else {
+ text.setFocus(true);
+ }
+ return;
}
}
--
1.7.0.4
Powered by
Google Project Hosting