My favorites
▼
|
Sign in
gerrit
Gerrit Code Review
Project Home
Downloads
Wiki
Issues
Source
Export to GitHub
New issue
Search
Search within:
All issues
Open issues
New issues
Issues to verify
for
Advanced search
Search tips
Subscriptions
Issue
1270
attachment: gerrit_warn_for_code_freeze.patch
(2.9 KB)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
index 3cddd2b..181e4e8 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
@@ -128,6 +128,7 @@ public interface ChangeConstants extends Constants {
String buttonReview();
String buttonPublishCommentsSend();
String buttonPublishSubmitSend();
+ String buttonPublishSubmitDuringCodeFreezeSend();
String buttonPublishCommentsCancel();
String headingCoverMessage();
String headingPatchComments();
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
index 35991f4..73ca8ba 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
@@ -111,6 +111,7 @@ buttonRestoreChangeSend = Restore Change
buttonReview = Review
buttonPublishCommentsSend = Publish Comments
buttonPublishSubmitSend = Publish and Submit
+buttonPublishSubmitDuringCodeFreezeSend = Publish and Submit DURING CODE FREEZE
buttonPublishCommentsCancel = Cancel
headingCoverMessage = Cover Message:
headingPatchComments = Patch Comments:
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java
index 03ddfd0..21bbe02 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java
@@ -113,6 +113,7 @@ public class PublishCommentScreen extends AccountScreen implements
buttonRow.add(send);
submit = new Button(Util.C.buttonPublishSubmitSend());
+
submit.addClickHandler(this);
buttonRow.add(submit);
@@ -314,6 +315,21 @@ public class PublishCommentScreen extends AccountScreen implements
if (Gerrit.getConfig().testChangeMerge()) {
submit.setEnabled(r.getChange().isMergeable());
}
+
+ if(submit.isEnabled() && isCodeFreeze(r.getChange()))
+ {
+ String branchName = r.getChange().getDest().get();
+ String project = r.getChange().getProject().get();
+ submit.setText(Util.C.buttonPublishSubmitDuringCodeFreezeSend() + project + ", branch: " + branchName);
+ }
+ }
+
+ private static boolean isCodeFreeze(Change forChange)
+ {
+ String branchName = forChange.getDest().get();
+ String project = forChange.getProject().get();
+ //TODO: do external lookup here
+ return true;
}
private void onSend(final boolean submit) {
Powered by
Google Project Hosting