Issue 28: build is broken
Status:  Fixed
Owner:
Closed:  Nov 2011
Project Member Reported by codeto...@gmail.com, Nov 30, 2011
I can't figure out how to comment on the check-in, but the unit tests do not compile via Gradle! 

The problem is changing Type in InvocationManager_UT from net.cglib to the new one.

I am reasonably sure I am in sync with repo with no local changes.

We need to do 'gradle clean test' before all check-ins.  
Nov 30, 2011
Project Member #1 kandpwel...@gmail.com
are you sure you merged OK?  The current import should be "net.sf.cglib.asm.Type;" instead of "org.objectweb.asm.Type;" which was a problem.  In fact, I don't know how it was compiling before, as CGLib required the use of net.sf.cglib.asm.  The other one (objectweb) is only present because of FunctionalJava.jar.
Nov 30, 2011
Project Member #2 codeto...@gmail.com
I'm very confused. I pulled a fresh copy (to a new dir) of the latest and confirmed that the tests will not compile. I tried to go back in time to find the breaking commit but that isn't working out, due to being a Git n00b.

I haven't branched or merged explicitly. I am fairly fanatical about running tests before check-ins. I don't know what is wrong. I might look at it later on after reading up on Git some more.
Nov 30, 2011
Project Member #3 codeto...@gmail.com
I have confirmed that it was commit id 'f679e25d2f9e' which changed the import from org.objectweb.asm.Type to the net.sf.cglib.asm.Type. (I changed it manually to try it)

Essentially, this means that the Gradle jars and the jars you are using in IntelliJ are different and incompatible. That is a bummer.

If you send me a canonical list of jars you are using in Intellij, I can try to fix it, perhaps. 
Nov 30, 2011
Project Member #4 kandpwel...@gmail.com
I think the problem is the combination of cglib and cglib-asm you have in gradle.

I would try the following change myself, but I am at work and can't test it, and don't want to make things worse for you.  Try replacing:
    compile group: 'cglib', name: 'cglib', version: '2.2'
    compile group: 'cglib', name: 'cglib-asm', version: '1.0'
with:
    compile group: 'cglib', name: 'cglib-nodep', version: '2.2'
The only reason we need the "Type" import is for the unit tests.  Nothing else requires a direct import of ASM classes at compile time, and I'm not sure how it was working at runtime.  This really was a needed correction, albeit an incomplete one from the Gradle build file perspective.

Again, sorry about not using Gradle build yet.  You would not believe how swamped I have been.  Now I know why OS projects sometimes seem like they are moving slow.  It feels like we are moving along pretty well, and yet stuff is always being added to the list -- amazing, for such a "simple" ;-) project.  I will make it a new priority to get me up and running in Gradle.

Nov 30, 2011
Project Member #5 codeto...@gmail.com
That worked on my machine! Thanks!

I will try to check-in but I upgraded my Mac to Snow Leopard and unfortunately the git stuff is broken. I'm surprised and disappointed.

Btw, we will be in different phases of motivation/availability so no pressure. Things get busy. (Though breaking the build is urgent, as you no doubt agree)
Status: Started
Nov 30, 2011
Project Member #6 kandpwel...@gmail.com
Great, feel free to close out the issue once it's checked in.
Nov 30, 2011
Project Member #9 codeto...@gmail.com
Updated build.gradle. All tests pass. Thanks again for the help!
Status: Fixed