My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 23: does InvocationManager need a full-blown stack?
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  codeto...@gmail.com
Closed:  Nov 2011


 
Project Member Reported by codeto...@gmail.com, Nov 26, 2011
I've realized that InvocationManager doesn't really need a Stack. It is simply pushing/popping one item.

I've written a version where InvocationManager simply holds an Invokable. All the tests pass. This seems simpler to understand and will be somewhat faster. It will also be easier to lock down for thread-safety, if we choose.

Is there any reason to use a Stack? e.g. for future design/features?



Nov 26, 2011
Project Member #1 codeto...@gmail.com
The new version could be considered a Toggle. You can do a get() and put() but they must be called in the proper order.
Summary: does InvocationManager need a full-blown stack?
Nov 29, 2011
Project Member #2 kandpwel...@gmail.com
yeah, I have been pondering that ever since I put it in.  If you have a simplification, then go for it.
Nov 29, 2011
Project Member #3 codeto...@gmail.com
Sounds fun... I'm on it
Status: Started
Nov 29, 2011
Project Member #4 codeto...@gmail.com
I've introduced InvokableState which is a simple wrapper around a pointer. Quite minimalist, though not thread-aware.

Tests for InvocationManager pass untouched and new tests for InvokableState.
Status: CodeComplete
Nov 29, 2011
Project Member #5 kandpwel...@gmail.com
Looks great.
Status: Fixed

Powered by Google Project Hosting