Issue 757: new events don't 'stick' after removing an event
Status:  Released
Owner: ----
Closed:  Aug 2013
Reported by ehudyali...@gmail.com, Dec 12, 2010
Bug description: If you had an event (don't even have to do that), remove an event, and then add a new event that should 'stick', the new event doesn't really stick.

Bug cause: It happens because that 'dynamicEventSource' array to which sticking events are added reference becomes irrelevant after removing and event (it is being filtered and copied).

Suggested fix: Save the dynamicEventSource id in the sources array and not the array refernce

Line 868:
- var dynamicEventSource = [];
+ var dynamicEventSourceId;

Line 951:
- sources.push(dynamicEventSource)
+ dynamicEventSourceId = sources.push([]) - 1;

Lines 1015-1016:
- dynamicEventSource.push(event);
- event.source = dynamicEventSource;
+ sources[dynamicEventSourceId].push(event);
+ event.source = sources[dynamicEventSourceId];

I know it fixes the specific bug, but I haven't checked if there are any other similar bugs regarding the sources list (sources references being lost).

Thanks for the great control!

For questions regarding the bug or the fix,
Ehud Yalin-Mor
ehud@vmeetme.com

Dec 26, 2010
Project Member #1 adamrs...@gmail.com
i understand, thank you for investigating, will get this fixed in the next version
Summary: new events don't 'stick' after removing an event
Status: Accepted
Labels: Type-Defect
Jan 2, 2011
Project Member #2 adamrs...@gmail.com
this is fixed in 1.4.10, just released. thanks
Status: Fixed
Aug 13, 2013
Project Member #3 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Implemented
Aug 13, 2013
Project Member #4 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Released