My favorites | Sign in
Project Home Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2507: lang files should name fullcalendar as a dependency
1 person starred this issue and may be notified of changes. Back to list
Status:  ExportedToGithub
Owner:  ----
Closed:  Aug 2015


Sign in to add a comment
 
Reported by brunopie...@gmail.com, May 21, 2015
As fullcalendar-locales.js depends on fullcalendar.js
It should be added in the dependancy in the top "define()" call

May 26, 2015
Project Member #1 adamrs...@gmail.com
hmm, this could be a little more complicated than that because the language file would need to reference fullcalendar as a dependency by name like "fullcalendar" and some people would be turned off by that. gotta think about that more. any ideas welcome on how exactly to write the AMD declarations.
Summary: lang files should name fullcalendar as a dependency (was: Missing dependancy in fullcalendar-locales.js)
Status: Discussing
Labels: Type-Feature
May 26, 2015
#2 brunopie...@gmail.com
It might be named "./fullcalendar", it will impose the files to be in the same folder.
I don't know the real spec of AMD, but with requirejs it works.

Maybe it might not working if the path of fullcalendar itself has been rewritten by the config, but in this case, fullcalendar-locales should have been too.
Aug 20, 2015
Project Member #3 adamrs...@gmail.com
Discussion for this issue has moved to the following URL:
https://github.com/fullcalendar/fullcalendar/issues/2772

This is because Google Code is shutting down. Apologies if you are being pestered with these notifications. This is a one-time event.

Happy coding,
Adam
Status: ExportedToGithub
Sign in to add a comment

Powered by Google Project Hosting