My favorites | Sign in
Project Home Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2191: Regression for addEventSource in 2.0.1, event source doesn't persist over week change
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jun 2014


Sign in to add a comment
 
Reported by tatu.ter...@gmail.com, Jun 23, 2014
See this jsfiddle for simplified example: http://jsfiddle.net/arshaw/3E8nk/

Steps to reproduce:
1. Add an event source -object using addEventSource(eventSourceObject);
2. Click to open previous week
3. Click to open next week (this week)
4. Any events added by the event source have disappeared.

This seems to be a regression, 2.0.0 works as I'd expect. 

According to following commit buildEventSource has lost a sources.push() which might be the reason for this.
https://github.com/arshaw/fullcalendar/commit/33ef246fd925e583c4b5b74bd2d3346df475dbf9

Br,
Tatu


Jun 23, 2014
#1 tatu.ter...@gmail.com
Apparently messed up the jsfiddle url, the correct one: http://jsfiddle.net/de47N/
Jun 23, 2014
Project Member #2 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Reproducing
Labels: Type-Bug
Jun 23, 2014
Project Member #3 adamrs...@gmail.com
i can confirm this. fiddle with correct fc version: http://jsfiddle.net/de47N/1/

thanks!
Status: Accepted
Jun 23, 2014
#4 tatu.ter...@gmail.com
my pleasure, thanks for fullcalendar! :)
Jun 24, 2014
#5 van.wijg...@mdxs.net
On 2014-06-23, acutus commented on a commit that "This line might be the reason for  issue #2191 ": https://github.com/arshaw/fullcalendar/commit/33ef246fd925e583c4b5b74bd2d3346df475dbf9#commitcomment-6767972
Jun 24, 2014
#6 pierre.a...@gmail.com
I can confirm this behaviour. I had to go back to the 2.0.0 to avoid this problem.
Jun 24, 2014
#7 van.wijg...@mdxs.net
Tested a bit more and found that switching views sometimes does and sometimes doesn't cause the event to stay around.

See http://jsfiddle.net/wijgerden/cxtMd/ for a slightly changed example.

On first run, the event is visible. Now change between the default 'agendaWeek' to any of the 'basicWeek', 'agendayDay', or 'basicDay' views and the event remains (may need to scroll vertically to see it). Same when switching back to 'agendaWeek' and between any of the above mentioned week/day views.

However, as soon as you switch to the 'month' view the event is gone... to never return. Similar to using the 'previous' or 'next' buttons on any of the week views and going back (as the original poster described).

Strangely enough, run again go to any of the day views, use prev/next and return back to today... the event remains; but I guess only as long as you don't leave that week's boundaries.
Jun 24, 2014
#8 van.wijg...@mdxs.net
Adding a forced "fc.fullCalendar('refetchEvents');" as in http://jsfiddle.net/wijgerden/cxtMd/1/ shows (I think) that the bug occurs when the event data is being fetched again.
Jun 24, 2014
Project Member #10 adamrs...@gmail.com
released: https://github.com/arshaw/fullcalendar/releases

thanks for the bug reports & fiddles
Status: Released
Jun 24, 2014
#11 tatu.ter...@gmail.com
Great!
Jun 25, 2014
#12 pierre.a...@gmail.com
Thanks Adam and everyone for your responsiveness!
Sign in to add a comment

Powered by Google Project Hosting