My favorites | Sign in
Project Home Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2186: Eliminate table use for layout
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Aug 2014


Sign in to add a comment
 
Reported by slserp...@gmail.com, Jun 17, 2014
Full Calendar is using tables in a number of places for layout: the header and in several calendar underlays for various reasons. Using tables for layout is considered bad form (see http://phrogz.net/css/WhyTablesAreBadForLayout.html for one). And for me, already having special table styling for actual tables, is going to require that I specifically override those styles just to use this script.

I'm sure there are some very good reasons for the use of tables for some of the calendar layers, seeing as calendars are rather tabular in nature. At the very least, the header table must go; it should be very easy to reproduce with floated divs.
Jun 22, 2014
Project Member #1 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Labels: Type-Behavior milestone-skeleton
Jul 23, 2014
Project Member #2 adamrs...@gmail.com
The header area now uses divs+css for positioning
in v2.1 (beta)
http://blog.arshaw.com/1/post/2014/07/fullcalendar-210-beta.html

I would really appreciate if you could verify this. Thanks a lot!
Jul 23, 2014
Project Member #3 adamrs...@gmail.com
had to continue using tables for other things mainly because we needed the `colspan` and `rowspan` capabilities for the new type of event rending we're doing. also, real tables play better when doing print stylesheets (trust me.. messed around w/ x-browsers problems a lot).
Jul 23, 2014
#4 slserp...@gmail.com
Thanks for looking into this so quickly. I like what you're doing with this library, and I didn't want to see it get panned by the hardcore developers for using tables for layout.

I temporarily inserted the beta version into my project to give it a look. The header looks perfectly implemented. However, you might want to add a top margin to .fc-toolbar h2.

Looking at the beta as a whole, I did notice a few other things that bothered me. The first being an apparent issue with setting the height in the calendar options. At least for me, if the height was set larger than the calendar needed, it caused certain layers of the calendar to extend outside of the rest of the calendar. Would be great if when the calendar height was set to larger than needed or set to something like "auto", that the calendar would just appear without any scrollbar, as that would probably be the desired effect.

In agenda week view, the event element labels always have the time on one line and the title on the next even for short events. In the previous version, short events (30 mins) had their time and title on only one line and it looked much better. Also, the cursor used for events is now set to "default" instead of "pointer". I feel like when the event has a url associated, it should be set to cursor: pointer for usability.

Hope this helps. Sorry that it's a little more than you asked for. ;)
Jul 27, 2014
Project Member #5 adamrs...@gmail.com
For the height/scrolling issue, I'm still figuring out what the best defaults are, but I have actually introduced an "auto" option. If you set height:"auto", no scrollbars will appear and the height won't be taller than it needs to be (most importantly in agenda views).

for the cursor issue, i could have sworn it is a pointer if there is an href. gotta look into it.
Aug 14, 2014
Project Member #6 adamrs...@gmail.com
(No comment was entered for this change.)
Status: Implemented
Aug 26, 2014
Project Member #7 adamrs...@gmail.com
This issue has been resolved with the official release of v2.1.0:
http://blog.arshaw.com/1/post/2014/08/fullcalendar-210-released.html

Please post any follow-up bug reports or feature requests as separate issues. Thanks.
Status: Released
Sign in to add a comment

Powered by Google Project Hosting