| Issue 1035: | On select click event selection start below mouse position | |
| 16 people starred this issue and may be notified of changes. | Back to list |
On version 1.5.1 When selecting on week or day view selecting start below mouse position.
This gap form mouse position grows as you go down the rows.
Apparently the position calculated based on slotTableFirstInner size without taking into account the fact that the position calculation should include all row children(the th height > td height)
A quick fix was changing in AgendaView.setHeight
function setHeight(height, dateChanged) {
if (height === undefined) {
height = viewHeight;
}
viewHeight = height;
slotTopCache = {};
var headHeight = dayBody.position().top;
var allDayHeight = slotScroller.position().top; // including divider
var bodyHeight = Math.min( // total body height, including borders
height - headHeight, // when scrollbars
slotTable.height() + allDayHeight + 1 // when no scrollbars. +1 for bottom border
);
dayBodyFirstCellStretcher
.height(bodyHeight - vsides(dayBodyFirstCell));
slotLayer.css('top', headHeight);
slotScroller.height(bodyHeight - allDayHeight - 1);
++slotHeight = slotTableFirstInner.parents('tr').outerHeight() + 1; // +1 for border
--slotHeight = slotTableFirstInner.height() + 1; // +1 for border
if (dateChanged) {
resetScroll();
}
}
Aug 24, 2011
#1
albertca...@gmail.com
Sep 29, 2011
i'm not sure i understand the original problem. could you explain it a little better? (step-by-step what you need to do)? thanks!
Status:
Reproducing
Dec 20, 2011
Thank you! You can reproduce this issue still in 1.5.2 when you change the .fc-agenda-slots td div { height: 20px; } to instead be height:10px and then drag/drop external objects onto the full-day agenda.
Dec 20, 2011
Uh! i didn't receive the previous mail. As already said, you have to change the height in the CSS and then drag&drop events.
Dec 28, 2011
Hey Adam, I'm running into the problem described here but maybe I can do a better job of explaining it... Basically what is happening is that where you actually "click" on the calendar and where an event selection actually starts is inconsistent. The point the original poster was making was that the inconsistency increases as you get further down in the calendar (as you go later in the day). I'm not exactly sure what code might need to be changed in order to fix that, but it does seem like the calculation made to determine the start of the event selection, based on a positional click, would need to be updated.
Dec 29, 2011
The code change proposed works perfect, that's what i have in my fullcalendar.sj
++slotHeight = slotTableFirstInner.parents('tr').outerHeight() + 1; // +1 for border
--slotHeight = slotTableFirstInner.height() + 1; // +1 for border
in the setHeight function
May 29, 2012
Working example of bug http://jsbin.com/iviyeb/edit#javascript,html,live The slot height is set to 10px by CSS. Try to add an event in weekview at 5pm...
May 31, 2012
By the way: This worked for me slotHeight = slotTable.height()/slotCnt; (In my case, the original slotHeight function returned 11px, whereas in reality, the height was 11.49305555555px.
Jun 20, 2012
Also for me is correct calculate the height with slotHeight = slotTable.height()/slotCnt; It works fine. Tnx a lot
Jul 18, 2013
slotHeight = slotTable.height()/slotCnt; It works perfectly, thx.
Aug 13, 2013
(No comment was entered for this change.)
Status:
Accepted
Labels: -Type-Defect Type-Bug
Aug 13, 2013
Issue 1034 has been merged into this issue.
Aug 14, 2013
Issue 1149 has been merged into this issue.
Aug 14, 2013
Issue 1216 has been merged into this issue.
Aug 14, 2013
Issue 1229 has been merged into this issue.
Aug 15, 2013
Issue 1430 has been merged into this issue.
Aug 15, 2013
Issue 1626 has been merged into this issue.
Aug 15, 2013
Issue 1302 has been merged into this issue.
Aug 28, 2013
(No comment was entered for this change.)
Labels:
milestone-1.6.4
Aug 31, 2013
https://github.com/arshaw/fullcalendar/commit/bc0883f8f0fe42b3a46f3f4adc082cc1ccb471bb
Status:
Implemented
Sep 1, 2013
this has been released v1.6.4 https://github.com/arshaw/fullcalendar/blob/v1.6.4/changelog.txt
Status:
Released
|
|
| ► Sign in to add a comment |