| Issue 2195: | Might be wrong at mutateEvent -- logic of find out allDay | |
| 1 person starred this issue and may be notified of changes. | Back to list |
FullCalendar 2.0.2
function: mutateEvent (line: 1797)
I think there is a problem at this part:
================================================================
// detect new allDay
if (event.allDay != oldAllDay) { // if value has changed, use it
newAllDay = event.allDay;
}
else { // otherwise, see if any of the new dates are allDay
newAllDay = !(newStart || newEnd).hasTime();
}
================================================================
the allDay field should have the first priority. if it didn't change, just
use it as it is, no need to guess it from the start and end.
for example, I have this event:
{
title: 'meeting',
start: '2014-06-26T00:30:00Z',
allDay: true
}
this event was rendered correctly on first display, if I update this event's title (and only update title) to 'all day meeting' and call 'updateEvent' method, the event's allDay field will be set to false cause the start got time part on it. and event was rerendered as non-allDay event.
I think this is not right.
Jul 3, 2014
Project Member
#1
adamrs...@gmail.com
Status:
Done
|
|
| ► Sign in to add a comment |