My favorites | Sign in
Project Home Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2463: fc-helper class name needs a space before concat
1 person starred this issue and may be notified of changes. Back to list
Status:  ExportedToGithub
Owner:  ----
Closed:  Aug 2015


Sign in to add a comment
 
Reported by mark...@ooyala.com, Mar 16, 2015
in the javascript you add fc-helper with

	fakeEvent.className = (fakeEvent.className || []).concat('fc-helper');

around line 3193:

That will add the last class names together. This may only be an issue if using event.className

The line should be ->

fakeEvent.className = (fakeEvent.className || []).concat(' fc-helper');
	
Mar 16, 2015
Project Member #1 adamrs...@gmail.com
There is no bug, the spaces between the classnames are added in when the array is join'd together later on.

If you still feel there is a bug, please follow these instructions:
http://fullcalendar.io/wiki/Reporting-Bugs/
Status: Invalid
Mar 16, 2015
#2 mark...@ooyala.com
className is a string not an array. 

Here is the innerHTML from the div.fc-helper-skeleton

innerHTML: "<div class="fc-helper-skeleton" style="opacity: 1;"><table><tbody><tr><td class="fc-axis" style="width:35px"></td><td><div class="fc-event-container"><a class="fc-time-grid-event fc-v-event fc-event fc-start fc-end  fc-state-pastfc-helper  fc-draggable fc-resizable"  ...

Is only when you set your own class and drag it uses the helper.  It very much messes up.  
fc-state-past  is my className class. I tired to use fc-helper for drag and no luck.

I dont really care if you fix it, I just added a space at the end of my classes.
Mar 16, 2015
#3 mark...@ooyala.com
I meant to say fakeEvent.className is a string not an array of strings.
Mar 16, 2015
Project Member #4 adamrs...@gmail.com
sorry, ill look into it
Status: Reproducing
Labels: Type-Bug
Mar 16, 2015
#5 mark...@ooyala.com
Thank you.
I didnt realize that until your comment that className can be a string or array of strings. 
There is probably a better fix than a space.
Aug 21, 2015
Project Member #6 adamrs...@gmail.com
Discussion for this issue has moved to the following URL:
https://github.com/fullcalendar/fullcalendar/issues/2728

This is because Google Code is shutting down. Apologies if you are being pestered with these notifications. This is a one-time event.

Happy coding,
Adam
Status: ExportedToGithub
Sign in to add a comment

Powered by Google Project Hosting